Fixes a bug in the conversion from a flattened 1D array representation to a rank-2 array.#314
Closed
abhiyanpaudel wants to merge 1 commit into
Closed
Fixes a bug in the conversion from a flattened 1D array representation to a rank-2 array.#314abhiyanpaudel wants to merge 1 commit into
abhiyanpaudel wants to merge 1 commit into
Conversation
Collaborator
|
@Sichao25 Can you confirm that this is resolved in the new branch? |
Contributor
|
Yes, we created a new helper function to construct a Kokkos View from an Omega_h array. |
Collaborator
|
I believe we addressed this. Please reopen if this comes up again in current version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous conversion could produce incorrect indexing/layout when reshaping data from a 1D flattened representation into a rank-2 array. This bug was found while working on PR #300.