Skip to content

adding global_id_name to create_field #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobmerson merged 5 commits into from
Mar 8, 2026
+4 −4
Merged

adding global_id_name to create_field #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80f79f4
add_global_id
Feb 20, 2026
6132c0f
Merge branch 'develop' into add_global_id
hgangwar Mar 5, 2026
599b671
merged_develop
Mar 6, 2026
211dc19
merged_develop
Mar 6, 2026
998bd66
format
Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pcms/create_field.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace pcms

std::unique_ptr<FieldLayout> CreateLagrangeLayout(
Omega_h::Mesh& mesh, int order, int num_components,
CoordinateSystem coordinate_system)
CoordinateSystem coordinate_system, std::string global_id_name)
{

std::array<int, 4> nodes_per_dim;
Expand All @@ -25,8 +25,8 @@ std::unique_ptr<FieldLayout> CreateLagrangeLayout(
default: throw std::runtime_error("Unimplemented order");
}

return std::make_unique<OmegaHFieldLayout>(mesh, nodes_per_dim,
num_components, coordinate_system);
return std::make_unique<OmegaHFieldLayout>(
mesh, nodes_per_dim, num_components, coordinate_system, global_id_name);
}

template <>
Expand Down
2 changes: 1 addition & 1 deletion src/pcms/create_field.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace pcms
{
std::unique_ptr<FieldLayout> CreateLagrangeLayout(
Omega_h::Mesh& mesh, int order, int num_components,
CoordinateSystem coordinate_system);
CoordinateSystem coordinate_system, std::string global_id_name = "global");

/**
* \brief Create a binary field on a uniform grid indicating inside/outside mesh
Expand Down