Fix DWD group analysis producing broken plots#2528
Open
akenmorris wants to merge 1 commit intomasterfrom
Open
Conversation
DWD's discriminant direction optimizes for margin, not mean separation, so it can be nearly orthogonal to the group mean difference. The normalize() function divides by the mean projection gap, which blows up when that gap is near-zero, producing shape mappings at ±100 and flat PDFs. Skip mean-based normalization for DWD and use raw unit-length projections with adaptive PDF x-ranges instead. Also scale scatter dot y-position to peak PDF height so dots stay at the plot bottom regardless of PDF scale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DWD's discriminant direction optimizes for margin, not mean separation, so it can be nearly orthogonal to the group mean difference. The normalize() function divides by the mean projection gap, which blows up when that gap is near-zero, producing shape mappings at ±100 and flat PDFs. Skip mean-based normalization for DWD and use raw unit-length projections with adaptive PDF x-ranges instead. Also scale scatter dot y-position to peak PDF height so dots stay at the plot bottom regardless of PDF scale.