Add coefficient extraction and variance-ratio controls to MorphologicalDeviationSc#2525
Merged
akenmorris merged 1 commit intomasterfrom Mar 26, 2026
Merged
Add coefficient extraction and variance-ratio controls to MorphologicalDeviationSc#2525akenmorris merged 1 commit intomasterfrom
akenmorris merged 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends MorphologicalDeviationScore with coefficient access and exposes the functionality thru Python.
Changes Made
Added
GetPCACoefficients(const Eigen::MatrixXd& X)to project samples onto the fitted PCA basis and return the coefficient matrix.Added public retained-variance controls, to better allow manual variance control in MophoDevScoring:
SetRetainedVarianceRatio(double ratio)GetRetainedVarianceRatio() constAdded Python bindings for:
GetPCACoefficientsSetRetainedVarianceRatioGetRetainedVarianceRatioTesting