Send Discord notifications for rollback failures#36
Open
NDB-7 wants to merge 2 commits intoSCE-Development:mainfrom
Open
Send Discord notifications for rollback failures#36NDB-7 wants to merge 2 commits intoSCE-Development:mainfrom
NDB-7 wants to merge 2 commits intoSCE-Development:mainfrom
Conversation
adarshm11
reviewed
Mar 31, 2026
| subprocess.run(["docker-compose", "up", "--build", "-d"], cwd=repo_cfg.path, check=True) | ||
| return True | ||
| except Exception: | ||
| logger.warning(f"Rolling back {repo_cfg.name} to {backup_name}") |
Contributor
There was a problem hiding this comment.
lets keep the try/catch/finally block here because without it there will be uncaught exceptions from the subprocess runs
9a1aab8 to
8ef6d1e
Compare
adarshm11
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For issue #34
Steps to test
enable_rollbackistrueinconfig.ymldocker-compose.ymlin a way that makesdocker-compose up --build -dtrigger an errorpython server.pycurlon that repo and local branch:After the webhook event, the Git step will trigger an error, initiating a rollback. During the rollback, the Docker step will fail, resulting in a rollback failure.
Here's my config:

Logs
Command line output:


Discord embed output: