feat(DM01-6092): add endpoint to get project secrets with decrypted values#630
Closed
Jiachen0715 wants to merge 1 commit into
Closed
feat(DM01-6092): add endpoint to get project secrets with decrypted values#630Jiachen0715 wants to merge 1 commit into
Jiachen0715 wants to merge 1 commit into
Conversation
…alues Add GET /api/v1/projects/<project_id>/secrets/values returning each secret's name and decrypted plaintext value for a project. - New SecretValues resource: validates project uuid (400), returns 404 when the project does not exist, decrypts each secret value. - New OPA rule allowing GET on the .../secrets/values path, reusing the existing project-administrator gate (user token + role >= 20). WARNING: this endpoint exposes plaintext secret values; access is restricted to project administrators by the OPA policy.
Contributor
Author
|
Superseded by #631, which folds in this /secrets/values endpoint and adds the temporary read-token two-factor gate. Continuing there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
GET /api/v1/projects/<project_id>/secrets/valueswhich returns eachsecret's name and decrypted plaintext value for a project.
Changes
SecretValuesresource insrc/api/handlers/projects/secrets.py:400on malformed id)404when the project does not existdecrypt_secretsrc/openpolicyagent/policies/projects_secrets.regoallowing
GETon the.../secrets/valuespath, reusing the existingproject-administrator gate (user token + role >= 20).
Impact
restricted to project administrators by the OPA policy.
INFRABOX_RSA_PRIVATE_KEY_PATHto decrypt values (already present in the API pod).
Testing