Reduce client side loading in layout.tsx (and update dependencies)#5
Open
ranidspace wants to merge 2 commits into
Open
Reduce client side loading in layout.tsx (and update dependencies)#5ranidspace wants to merge 2 commits into
ranidspace wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address the rate limiting from cloudflare, though I didn't get very far.
Dependencies were updated, some older dependency may have been causing issues, but I can't say. ("@types/cookie" was deprecated and no longer needed)
In
layout.tsxthe child content is wrapped in a "RouteGuard" which does some server side checks on if routes exist, and if the site requires a password and if the user is authenticated. Currently none of the pages require any of these checks.Since these checks are performed server side, and the client then needs to render the page with javascript, this causes more requests to be done for every page. With the RouteGuard removed it's able to, for the most part, render the pages statically, and perhaps reduce traffic a bit.
There's more ways to reduce traffic however I feel a lot of it comes from dependencies which can't be changed