Skip to content

Fix connection haningin on closed port in windows #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tapetersen wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix connection haningin on closed port in windows #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/test_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,3 +941,13 @@ async def main() -> None:
transport.close()

rsloop.run(main())

def test_open_connection_errors_fast_on_refuse(self) -> None:
"""Ensure we fail fast when connecting to a closed port."""
async def main() -> None:
loop = asyncio.get_running_loop()
with self.assertRaises(ConnectionRefusedError):
transport, _ = await asyncio.wait_for(loop.create_connection(asyncio.Protocol, host="127.0.0.1", port=53673), timeout=3.0)
transport.close()

rsloop.run(main())