Skip to content

fix(ecdsa): narrow hex char validation in Signature::from_str #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PrarthanaPurohit wants to merge 3 commits into from
Closed

fix(ecdsa): narrow hex char validation in Signature::from_str #1253

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51fa0ff
fix(ecdsa): narrow hex char validation in Signature::from_str
PrarthanaPurohit Mar 15, 2026
2d40a51
ecdsa: fix hex validation in Signature::from_str to use is_ascii_hexd…
PrarthanaPurohit Mar 15, 2026
a14d7d1
fix(ecdsa): apply cargo fmt to hex validation code
PrarthanaPurohit Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ecdsa/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,11 +438,7 @@ where
}

// This check is mainly to ensure `hex.split_at` below won't panic
if !hex
.as_bytes()
.iter()
.all(|&byte| matches!(byte, b'0'..=b'9' | b'a'..=b'z' | b'A'..=b'Z'))
{
if !hex.as_bytes().iter().all(|&byte| byte.is_ascii_hexdigit()) {
return Err(Error::new());
}

Expand Down
Loading