Skip to content

Update comparison methods for UintRef#1311

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
andrewwhitehead:fix/uintref-eq
Jun 26, 2026
Merged

Update comparison methods for UintRef#1311
tarcieri merged 1 commit into
RustCrypto:masterfrom
andrewwhitehead:fix/uintref-eq

Conversation

@andrewwhitehead

@andrewwhitehead andrewwhitehead commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

UintRef was deriving PartialEq, which simply compared the limb slices and was not constant-time. This makes the PartialEq implementation use CtEq, consistent with Uint and BoxedUint. It also adds PartialOrd and Ord implementations.

…istent with Uint

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.99%. Comparing base (2021752) to head (87073e3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1311   +/-   ##
=======================================
  Coverage   90.99%   90.99%           
=======================================
  Files         189      189           
  Lines       22560    22573   +13     
=======================================
+ Hits        20528    20541   +13     
  Misses       2032     2032           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tarcieri tarcieri merged commit dc7ee98 into RustCrypto:master Jun 26, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants