Fixes for exact division edge cases#1310
Merged
tarcieri merged 4 commits intoJun 26, 2026
Merged
Conversation
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
…und zero-valued limbs Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
commented
Jun 25, 2026
| } | ||
|
|
||
| #[test] | ||
| // TODO: expand to f in uint(), g in uint() |
Contributor
Author
There was a problem hiding this comment.
Changing this highlights the issue fixed by #1291
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
==========================================
+ Coverage 90.99% 91.03% +0.04%
==========================================
Files 189 189
Lines 22560 22585 +25
==========================================
+ Hits 20528 20561 +33
+ Misses 2032 2024 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This does make the test runs significantly slower at the moment, I'll look at reducing the frequency of tests for larger BoxedUints. |
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
tarcieri
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds fixes for a couple types of inputs that were not producing the correct result:
The suite of proptests for BoxedUint are updated to explicitly create inputs with a single bit set, only high bits set, and only low bits set (which also detects these issues). Some tests are expanded to test differently-sized inputs where this was not being exercised before.