feat: process-unique client names in PulseAudio and PipeWire#1213
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes cpal’s PulseAudio and PipeWire identities process-unique by incorporating the current process ID into the created client/stream names, improving distinguishability when multiple cpal-based processes run simultaneously (e.g., in pavucontrol and pw-top).
Changes:
- PulseAudio: suffix the client name with the process ID during
Client::from_envinitialization. - PipeWire: suffix playback and capture stream names with the process ID when creating
StreamRc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/host/pulseaudio/mod.rs |
Builds a process-unique PulseAudio client name using std::process::id(). |
src/host/pipewire/stream.rs |
Builds process-unique PipeWire playback/capture stream names using std::process::id(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple cpal processes are running, this is the only way to discern between them in tools like
pw-toporpavucontrol.