fix: enforce denied commands before auto-approval guard (#12292)

[roomote-v0]

This PR attempts to address Issue #12292.

Problem

Denied commands were only checked inside the alwaysAllowExecute guard in checkAutoApproval(). This meant denied commands were completely bypassed when:

• autoApprovalEnabled was disabled (early return on line 62)
• alwaysAllowExecute was disabled (fell through to "ask" without checking deny list)

As reported, allowed commands effectively fired before denied commands were checked, allowing agents to bypass security by wrapping denied commands inside chained commands.

Fix

Moved the denied commands check to run before the autoApprovalEnabled early return in checkAutoApproval(). This ensures denied commands act as an absolute safety net that cannot be bypassed regardless of auto-approval or auto-execute settings.

The existing getCommandDecision() function already handles:

• Splitting chained commands (&&, ||, ;, |)
• Longest prefix match conflict resolution between allow/deny lists
• Dangerous substitution detection

Tests

Added 9 new tests in checkAutoApproval.spec.ts covering:

• Denied commands blocked when autoApprovalEnabled is false
• Denied commands blocked when alwaysAllowExecute is false
• Denied commands blocked when alwaysAllowExecute is true
• Denied commands inside && chains are caught
• Denied commands in heredoc-style wrapping are caught
• Non-denied commands still return "ask" (not falsely denied)
• Empty deny list does not block commands
• Undefined state does not block commands
• Longest prefix match still works (more specific allowed overrides denied)

Feedback and guidance are welcome.

Interactively review PR in Roo Code Cloud