feat: add red styling to denied commands in Auto Approve settings#12294
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
feat: add red styling to denied commands in Auto Approve settings#12294roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
Denied command tags in the Auto Approve settings now use red font color and a subtle red background tint (bg-red-500/20 text-red-500) to visually distinguish them from allowed commands. This matches the existing red styling pattern used in CommandPatternSelector. Addresses feedback from Issue #12292.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12292
Description
This PR attempts to address a suggestion from Issue #12292 by @PlanBernhard to visually distinguish denied commands with red font color in the Auto Approve settings UI.
Changes:
text-red-500) and a subtle red background tint (bg-red-500/20), with a darker hover state (hover:bg-red-500/30)CommandPatternSelectorfor denied commands in the chat viewFeedback and guidance are welcome.
Test Procedure
SettingsView.spec.tsx:bg-red-500/20andtext-red-500classesSettingsView.spec.tsxpassCommandExecution.spec.tsxandCommandPatternSelector.spec.tsxpassPre-Submission Checklist
Documentation Updates
Additional Notes
The styling uses Tailwind CSS classes consistent with the project guidelines and matches the red styling pattern already established in
CommandPatternSelector.tsx(line 160).Interactively review PR in Roo Code Cloud