Skip to content

fix: add missing userMessageWasRemoved flag in manual retry for empty API responses #12291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-v0 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Draft

fix: add missing userMessageWasRemoved flag in manual retry for empty API responses #12291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2792,6 +2792,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
let assistantMessage = ""
let reasoningMessage = ""
let pendingGroundingSources: GroundingSource[] = []
let streamChunkCount = 0
this.isStreaming = true

try {
Expand Down Expand Up @@ -2830,6 +2831,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
continue
}

streamChunkCount++
switch (chunk.type) {
case "reasoning": {
reasoningMessage += chunk.text
Expand Down Expand Up @@ -3632,6 +3634,9 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// or tool_use content blocks from API which we should assume is
// an error.

console.log(
`[Task#${this.taskId}.${this.instanceId}] Empty API response: streamChunks=${streamChunkCount}, hasReasoning=${reasoningMessage.length > 0}, contentBlocks=${this.assistantMessageContent.length}`,
)
// Increment consecutive no-assistant-messages counter
this.consecutiveNoAssistantMessagesCount++

Expand Down Expand Up @@ -3695,10 +3700,12 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
await this.say("api_req_retried")

// Push the same content back to retry
// Mark that user message was removed so it gets re-added on retry
stack.push({
userContent: currentUserContent,
includeFileDetails: false,
retryAttempt: (currentItem.retryAttempt ?? 0) + 1,
userMessageWasRemoved: true,
})

// Continue to retry the request
Expand Down
Loading