fix: add null check for inputValue in ChatTextArea#11905
Open
Br1an67 wants to merge 1 commit intoRooCodeInc:mainfrom
Open
fix: add null check for inputValue in ChatTextArea#11905Br1an67 wants to merge 1 commit intoRooCodeInc:mainfrom
Br1an67 wants to merge 1 commit intoRooCodeInc:mainfrom
Conversation
The inputValue prop could be undefined when the component renders, causing a crash when calling .trim() on it. Added defensive null checks using fallback to empty string.
Br1an67
requested review from
cte,
daniel-lxs,
hannesrudolph,
jr and
mrubens
as code owners
dosubot
bot
added
the
size:XS
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11753
Summary
Added defensive null checks for
inputValueinChatTextArea.tsxto prevent "Cannot read properties of undefined (reading 'trim')" error. The fix ensures the component handles undefinedinputValuegracefully by using fallback values.Changes
hasInputContentuseMemo to use(inputValue || "").trim()instead ofinputValue.trim()handleEnhancePromptto use(inputValue || "").trim()instead ofinputValue.trim()Testing
Interactively review PR in Roo Code Cloud