feat: add GLM-5 model to Fireworks AI provider#11849
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
feat: add GLM-5 model to Fireworks AI provider#11849roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Issue #11830.
Changes
accounts/fireworks/models/glm-5to theFireworksModelIdtype union inpackages/types/src/providers/fireworks.tsfireworksModelsobject, following the same pattern as existing GLM models (GLM-4.6, GLM-4.7)src/api/providers/__tests__/fireworks.spec.tsAll tests pass (29/29) and type checks are clean.
Feedback and guidance are welcome.
Interactively review PR in Roo Code Cloud