Open
Conversation
…-final-task # Conflicts: # src/main/java/com/saucedemo/driver/managment/DriverManager.java # src/main/java/com/saucedemo/pages/LoginPage.java # src/main/java/com/saucedemo/tests/LoginTest.java
RomanNadia
commented
Aug 25, 2024
| break; | ||
| // TODO make default case | ||
| case CHROME: | ||
| default: |
RomanNadia
commented
Aug 25, 2024
| return driver; | ||
| } | ||
|
|
||
| // TODO remove it if u don't use it |
RomanNadia
commented
Aug 25, 2024
| public void setPassword(String password) { | ||
| this.password = password; | ||
| } | ||
|
|
Owner
Author
There was a problem hiding this comment.
added toString method for correct representation of user in logs
RomanNadia
commented
Aug 25, 2024
| private WebElement loginButton; | ||
|
|
||
| @FindBy(xpath = "//*[@data-test='error']") | ||
| private List<WebElement> errorMassage; // TODO massage is great thing, but we need message :) |
Owner
Author
There was a problem hiding this comment.
renamed and change type to WebElement
RomanNadia
commented
Aug 25, 2024
|
|
||
|
|
||
| public LoginPage enterLoginFields(User user) { | ||
| logger.info("Entering login fields for user: {}", user); // TODO in logs u will have object reference, not the value of user |
Owner
Author
There was a problem hiding this comment.
added toString method in User class
RomanNadia
commented
Aug 25, 2024
|
|
||
|
|
||
| public LoginPage enterUsername(String username) { | ||
| // TODO remove commented-out code if it is not needed or make initialisation of WebDriverWait in the constructor |
Owner
Author
There was a problem hiding this comment.
remove commented-out code
RomanNadia
commented
Aug 25, 2024
| logger.debug("Entered username: {}", username); | ||
| } else { | ||
| String password = passwordArea.getAttribute("value");; | ||
| // TODO I'm not quite understand why do we need get password and refresh page if username is empty |
Owner
Author
There was a problem hiding this comment.
I assume page is doing chashing (or something like that), so whithout refresh input fields remember old values which was set to them even after using method clear, so in the button click moment the old values are send.
RomanNadia
commented
Aug 25, 2024
| loginButton.click(); | ||
| logger.info("Clicked login button"); | ||
|
|
||
| if(driver.getCurrentUrl().equals("https://www.saucedemo.com/")) { // TODO to constants |
RomanNadia
commented
Aug 25, 2024
|
|
||
| public String getErrorMassageText() { | ||
| if(!errorMassage.isEmpty()) { | ||
| String fullText = errorMassage.get(0).getText(); |
Owner
Author
There was a problem hiding this comment.
errorMessage was made as WebElement. Also a check if element exists is remade
RomanNadia
commented
Aug 25, 2024
| public void testLoginWithCorrectInput() { | ||
| // TODO run this test and check logs, u testing 6 times that "standard_user" and "secret_sauce" are valid credentials | ||
| // TODO also u have this credentials in your DataProviderForLogin | ||
| User correctUser = new User("standard_user", "secret_sauce"); |
Owner
Author
There was a problem hiding this comment.
using user from DataProviderForLogin method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.