Rename ProcessingService last_checked fields to last_seen#1146
Draft
Rename ProcessingService last_checked fields to last_seen#1146
Conversation
…1122) Rename fields to better reflect the semantic difference between sync and async processing service status tracking: - last_checked → last_seen - last_checked_live → last_seen_live - last_checked_latency → last_seen_latency For sync services with endpoint URLs, fields are updated by the periodic status checker. For async/pull-mode services, a new mark_seen() method is called when the service registers pipelines, recording that we heard from it. Also updates all references in serializers, pipeline queryset, views, frontend models, columns, dialog, and language strings. Co-Authored-By: Claude <noreply@anthropic.com>
✅ Deploy Preview for antenna-ssec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1122
last_checked→last_seen,last_checked_live→last_seen_live,last_checked_latency→last_seen_latencyon theProcessingServicemodelmark_seen()method for async/pull-mode services to record liveness when they register pipelinesPOST /api/v2/projects/{id}/pipelines/) to callmark_seen(live=True)after successful registrationRenameField(data-preserving, no data loss)The naming better reflects the semantic difference between:
endpoint_url): Antenna actively checks the service via the periodic Celery Beat task, updatinglast_seen/last_seen_livefrom the health check responseendpoint_url): Workers report in by registering pipelines, and we record when we last heard from them viamark_seen()Test plan
mark_seen()method (live=True and live=False)last_seen/last_seen_liveTestProcessingServiceAPItests pass with renamed fieldsTestPipelineandTestProjectPipelinesAPItests pass