Skip to content

Sequence: flatten exports — remove API sub-object, export directly on global #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KenanMillet wants to merge 3 commits into from
Closed

Sequence: flatten exports — remove API sub-object, export directly on global #2271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cd00e8
Sequence: flatten exports — remove API sub-object, export directly on…
KenanMillet Jun 26, 2026
b105ddf
Sequence: remove Object.assign/delete API shim (no longer needed)
KenanMillet Jun 26, 2026
c281906
Sequence: treat msg.playerid='API' as GM for API-originated commands
KenanMillet Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 35 additions & 38 deletions Sequence/0.2.0/Sequence.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3260,7 +3260,7 @@ var Sequence = Sequence || (() => {
const handleInput = (msg) => {
if (msg.type !== 'api') return;
if (msg.content.split(' ')[0] !== CMD_TOKEN) return;
if (!playerIsGM(msg.playerid)) {
if (!playerIsGM(msg.playerid) && msg.playerid !== 'API') {
replyError(msg, 'Only the GM can use Sequence commands.');
return;
}
Expand Down Expand Up @@ -5395,49 +5395,46 @@ if (opacityReg) opacityReg.set(obj, 0.5);`
return {
checkInstall,
registerEventHandlers,
API: {
// Extension registration
registerAttribute,
registerPlaybackConstant,
registerEasing,
generateExtensionHandout,

// Registry introspection — returns struct or null
getAttribute: getAttrReg,
getFunction: (qualName) => {
const parts = qualName.split('.');
const ns = parts.length > 1 ? parts.slice(0, -1).join('.') : 'core';
const name = parts[parts.length - 1];
return FN_REGISTRY[`${ns}/${name}`] || null;
},
getConstant: (qualName) => {
const parts = qualName.split('.');
const ns = parts.length > 1 ? parts.slice(0, -1).join('.') : 'core';
const name = parts[parts.length - 1];
return CONST_REGISTRY[`${ns}/${name}`] || null;
},
getEasing,

// Playback control — for scripts that trigger playback programmatically
loadRecording,
startPlayback,
stopPlayback,
pausePlayback,
resumePlayback,
startRecording,
stopRecording,
saveRecording,

// Notify Sequence that a virtual attribute changed (for recording)
notifyChange,

// Extension registration
registerAttribute,
registerPlaybackConstant,
registerEasing,
generateExtensionHandout,

// Registry introspection — returns struct or null
getAttribute: getAttrReg,
getFunction: (qualName) => {
const parts = qualName.split('.');
const ns = parts.length > 1 ? parts.slice(0, -1).join('.') : 'core';
const name = parts[parts.length - 1];
return FN_REGISTRY[`${ns}/${name}`] || null;
},
getConstant: (qualName) => {
const parts = qualName.split('.');
const ns = parts.length > 1 ? parts.slice(0, -1).join('.') : 'core';
const name = parts[parts.length - 1];
return CONST_REGISTRY[`${ns}/${name}`] || null;
},
getEasing,

// Playback control — for scripts that trigger playback programmatically
loadRecording,
startPlayback,
stopPlayback,
pausePlayback,
resumePlayback,
startRecording,
stopRecording,
saveRecording,

// Notify Sequence that a virtual attribute changed (for recording)
notifyChange,
};
})();

on('ready', () => {
'use strict';
Sequence.checkInstall();
Sequence.registerEventHandlers();
Object.assign(Sequence, Sequence.API);
delete Sequence.API;
});
73 changes: 35 additions & 38 deletions Sequence/Sequence.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3260,7 +3260,7 @@ var Sequence = Sequence || (() => {
const handleInput = (msg) => {
if (msg.type !== 'api') return;
if (msg.content.split(' ')[0] !== CMD_TOKEN) return;
if (!playerIsGM(msg.playerid)) {
if (!playerIsGM(msg.playerid) && msg.playerid !== 'API') {
replyError(msg, 'Only the GM can use Sequence commands.');
return;
}
Expand Down Expand Up @@ -5395,49 +5395,46 @@ if (opacityReg) opacityReg.set(obj, 0.5);`
return {
checkInstall,
registerEventHandlers,
API: {
// Extension registration
registerAttribute,
registerPlaybackConstant,
registerEasing,
generateExtensionHandout,

// Registry introspection — returns struct or null
getAttribute: getAttrReg,
getFunction: (qualName) => {
const parts = qualName.split('.');
const ns = parts.length > 1 ? parts.slice(0, -1).join('.') : 'core';
const name = parts[parts.length - 1];
return FN_REGISTRY[`${ns}/${name}`] || null;
},
getConstant: (qualName) => {
const parts = qualName.split('.');
const ns = parts.length > 1 ? parts.slice(0, -1).join('.') : 'core';
const name = parts[parts.length - 1];
return CONST_REGISTRY[`${ns}/${name}`] || null;
},
getEasing,

// Playback control — for scripts that trigger playback programmatically
loadRecording,
startPlayback,
stopPlayback,
pausePlayback,
resumePlayback,
startRecording,
stopRecording,
saveRecording,

// Notify Sequence that a virtual attribute changed (for recording)
notifyChange,

// Extension registration
registerAttribute,
registerPlaybackConstant,
registerEasing,
generateExtensionHandout,

// Registry introspection — returns struct or null
getAttribute: getAttrReg,
getFunction: (qualName) => {
const parts = qualName.split('.');
const ns = parts.length > 1 ? parts.slice(0, -1).join('.') : 'core';
const name = parts[parts.length - 1];
return FN_REGISTRY[`${ns}/${name}`] || null;
},
getConstant: (qualName) => {
const parts = qualName.split('.');
const ns = parts.length > 1 ? parts.slice(0, -1).join('.') : 'core';
const name = parts[parts.length - 1];
return CONST_REGISTRY[`${ns}/${name}`] || null;
},
getEasing,

// Playback control — for scripts that trigger playback programmatically
loadRecording,
startPlayback,
stopPlayback,
pausePlayback,
resumePlayback,
startRecording,
stopRecording,
saveRecording,

// Notify Sequence that a virtual attribute changed (for recording)
notifyChange,
};
})();

on('ready', () => {
'use strict';
Sequence.checkInstall();
Sequence.registerEventHandlers();
Object.assign(Sequence, Sequence.API);
delete Sequence.API;
});
Loading