ENH: add AIGFS and HRRR Models to Forecast#951
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #951 +/- ##
===========================================
+ Coverage 80.27% 81.10% +0.83%
===========================================
Files 104 113 +9
Lines 12769 14542 +1773
===========================================
+ Hits 10250 11795 +1545
- Misses 2519 2747 +228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
does it really have to be slow test?
There was a problem hiding this comment.
All the tests that use set_atmospheric_model are marked as slow. I think now using THREDDS they are much faster, with NOMADS it used to take 1 minute per call, now its about 7~10 seconds. Given we have a bunch of them, the time adds up. So I´d still prefer to leave them marked as slow
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
LGTM, great addition, congrats @MateusStano !!
Pull request type
Checklist
Description
This PR adds support for two additional Forecast models that are easily available on THREDDS server
Also included new models in the documentation
Breaking change