Skip to content

ENH: add AIGFS and HRRR Models to Forecast#951

Merged
MateusStano merged 3 commits intodevelopfrom
enh/aigfs-and-hrrr
Apr 6, 2026
Merged

ENH: add AIGFS and HRRR Models to Forecast#951
MateusStano merged 3 commits intodevelopfrom
enh/aigfs-and-hrrr

Conversation

@MateusStano
Copy link
Copy Markdown
Member

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally

Description

This PR adds support for two additional Forecast models that are easily available on THREDDS server

  • AIGFS
  • HRRR

Also included new models in the documentation

Breaking change

  • Yes
  • No

@MateusStano MateusStano requested a review from a team as a code owner April 6, 2026 20:29
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 17.64706% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.10%. Comparing base (9cf3dd4) to head (0d324a5).
⚠️ Report is 71 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/environment/fetchers.py 10.00% 18 Missing ⚠️
rocketpy/environment/environment.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #951      +/-   ##
===========================================
+ Coverage    80.27%   81.10%   +0.83%     
===========================================
  Files          104      113       +9     
  Lines        12769    14542    +1773     
===========================================
+ Hits         10250    11795    +1545     
- Misses        2519     2747     +228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it really have to be slow test?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the tests that use set_atmospheric_model are marked as slow. I think now using THREDDS they are much faster, with NOMADS it used to take 1 minute per call, now its about 7~10 seconds. Given we have a bunch of them, the time adds up. So I´d still prefer to leave them marked as slow

Copy link
Copy Markdown
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great addition, congrats @MateusStano !!

@MateusStano MateusStano merged commit e2ddc45 into develop Apr 6, 2026
10 of 11 checks passed
@MateusStano MateusStano deleted the enh/aigfs-and-hrrr branch April 6, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants