ENH: Refactor flight.py latitude/longitude to use inverted_haversine#1055
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1055 +/- ##
===========================================
- Coverage 81.75% 81.74% -0.01%
===========================================
Files 119 119
Lines 15192 15198 +6
===========================================
+ Hits 12420 12424 +4
- Misses 2772 2774 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
just pending CHANGELOG.md update and codecoverage fix |
0c8c088 to
5024153
Compare
thc1006
pushed a commit
to thc1006/RocketPy
that referenced
this pull request
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes TODO comment about haversine in flight.py by importing and utilizing inverted_haversine from tools.py, and modifying tools.py inverted_haversine to support NumPy arrays.