feat: presence sync#7392
Open
Rohit3523 wants to merge 108 commits into
Open
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds timed status expiry to user presence across type definitions, REST API, presence propagation, status-editing UI, and room information surfaces. Introduces status source tracking and expiry formatting; threads expiry through presence streams and socket handlers; implements a clear-after picker with preset and custom date selection; renders expiry with clock icons in room headers and info views. Localization support added across 24 locales. ChangesTimed Status Expiry Feature
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rohit3523
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
Rohit3523
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (5)
app/containers/RoomHeader/RoomHeader.tsx (1)
119-126: ⚡ Quick winExtract inline style to StyleSheet for performance.
The inline style object
{ marginRight: 4 }creates a new object on every render. Per React Native best practices, extract it toStyleSheet.createto avoid unnecessary re-renders and improve performance.♻️ Proposed refactor
Add to the existing
stylesdefinition around line 30:const styles = StyleSheet.create({ container: { flex: 1, justifyContent: 'center' }, titleContainer: { alignItems: 'center', flexDirection: 'row' }, title: { flexShrink: 1, ...sharedStyles.textSemibold }, subtitle: { flexShrink: 1, ...sharedStyles.textRegular }, typingUsers: { ...sharedStyles.textSemibold + }, + clockIcon: { + marginRight: 4 } });Then update line 122:
- <CustomIcon name='clock' size={fontSize} color={colors.fontSecondaryInfo} style={{ marginRight: 4 }} /> + <CustomIcon name='clock' size={fontSize} color={colors.fontSecondaryInfo} style={styles.clockIcon} />🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/containers/RoomHeader/RoomHeader.tsx` around lines 119 - 126, The inline style { marginRight: 4 } on the CustomIcon in RoomHeader.tsx should be moved into the component's StyleSheet to avoid creating a new object each render; add a new style (e.g., iconSpacing or clockIcon) to the existing styles created with StyleSheet.create and include marginRight: 4 there, then replace style={{ marginRight: 4 }} on the CustomIcon with style={styles.iconSpacing} (keeping the existing styles.titleContainer reference intact).app/lib/methods/helpers/formatStatusExpiry.ts (2)
6-12: 💤 Low valueConsider computing "now" once for consistency.
The function calls
dayjs()on line 6 and again on line 10. While the performance impact is negligible, storing "now" in a single variable improves code clarity and eliminates the (extremely rare) edge case where midnight strikes between the two calls.♻️ Suggested refactor
export const formatStatusExpiry = (statusExpiresAt: string): string | undefined => { + const now = dayjs(); - const expiresAt = dayjs(statusExpiresAt); - if (!expiresAt.isValid() || !expiresAt.isAfter(dayjs())) { + const expiresAt = dayjs(statusExpiresAt); + if (!expiresAt.isValid() || !expiresAt.isAfter(now)) { return undefined; } - const now = dayjs(); - if (expiresAt.isSame(now, 'day')) {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/lib/methods/helpers/formatStatusExpiry.ts` around lines 6 - 12, The function currently calls dayjs() twice (once in the expiresAt.isAfter(dayjs()) check and again when assigning now), causing inconsistency; compute now once at the start (e.g., const now = dayjs()) and use that same now in the isAfter check and in the isSame(now, 'day') comparison so both validations reference the identical timestamp (update references to expiresAt.isAfter(now) and expiresAt.isSame(now, 'day')).
16-16: 💤 Low valueConsider combining format calls for brevity.
The date and time formatting can be combined into a single
.format()call.♻️ Suggested refactor
- return `${I18n.t('Until')} ${expiresAt.format('MMM D')}, ${expiresAt.format('h:mm A')}`; + return `${I18n.t('Until')} ${expiresAt.format('MMM D, h:mm A')}`;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/lib/methods/helpers/formatStatusExpiry.ts` at line 16, The return currently calls expiresAt.format twice; update formatStatusExpiry to call expiresAt.format once by combining the date and time pattern (e.g. 'MMM D, h:mm A') and use that single formatted string in the template; refer to the expiresAt variable and the formatStatusExpiry function to locate and change the expression accordingly.app/views/StatusView/ClearAfterPicker.tsx (1)
166-172: 💤 Low valueConsider defensive handling for edge case.
If
value === 'custom'butcustomDateisnull(line 167 condition fails), the function falls through to line 170-171. While this shouldn't occur in normal flow, a defensive check would improve robustness:🛡️ Optional defensive refactor
const getDisplayLabel = (): string => { if (value === 'custom' && customDate) { return customDate.toLocaleString(undefined, { month: 'short', day: 'numeric', hour: 'numeric', minute: '2-digit' }); } + if (value === 'custom' && !customDate) { + return I18n.t('Status_dont_clear'); + } const option = CLEAR_AFTER_OPTIONS.find(o => o.value === value); return option ? I18n.t(option.labelKey) : I18n.t('Status_dont_clear'); };🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/views/StatusView/ClearAfterPicker.tsx` around lines 166 - 172, getDisplayLabel currently assumes customDate exists when value === 'custom' and falls back to CLEAR_AFTER_OPTIONS lookup if it doesn't; add a defensive branch at the top of getDisplayLabel to handle the edge case where value === 'custom' but customDate is null/undefined by returning a safe fallback (e.g., I18n.t('Status_dont_clear') or another appropriate label) so the function never attempts to call toLocaleString on a null customDate; reference getDisplayLabel, value, customDate, CLEAR_AFTER_OPTIONS and I18n.t when making the change.app/views/StatusView/index.tsx (1)
117-118: 💤 Low valueConsider extracting version constant.
The version string
'8.6.0'is a magic value that determines feature availability. Extracting it to a named constant would improve maintainability:♻️ Optional refactor
+const MIN_VERSION_STATUS_EXPIRY = '8.6.0'; + const StatusView = (): React.ReactElement => { // ... const serverVersion = useSelector((state: IApplicationState) => state.server.version); - const supportsStatusExpiry = compareServerVersion(serverVersion as string, 'greaterThanOrEqualTo', '8.6.0'); + const supportsStatusExpiry = compareServerVersion(serverVersion as string, 'greaterThanOrEqualTo', MIN_VERSION_STATUS_EXPIRY);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/views/StatusView/index.tsx` around lines 117 - 118, Extract the magic version string '8.6.0' into a named constant (e.g., STATUS_EXPIRY_MIN_VERSION) and use that constant in the compareServerVersion call that sets supportsStatusExpiry; update the declaration around serverVersion, supportsStatusExpiry and compareServerVersion usages so they reference STATUS_EXPIRY_MIN_VERSION instead of the literal string to improve readability and maintainability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/i18n/locales/en.json`:
- Line 975: The en.json introduces the localized key "Until" (and potentially
"Status") but those same keys are missing from the other locale files (es, fi,
fr, hi-IN), causing fallbacks; add matching keys "Until" and "Status" to each
locale JSON present in app/i18n (es, fi, fr, hi-IN) with appropriate
translations or safe placeholder strings, keep the key names identical to the
en.json entries, maintain existing JSON ordering/formatting conventions, and run
the i18n validation/lint script to ensure no missing keys remain.
In `@app/i18n/locales/nn.json`:
- Line 401: The value for the key Status_clear_after_hint contains a
mixed-script typo ("Kalenderintegrасjonar"); open the JSON entry for
Status_clear_after_hint and replace the non-Latin characters with the correct
Latin spelling ("Kalenderintegrasjonar") so the string reads correctly: "Når
denne nye statusen vert nytta, kan han verta endra av: Kalenderintegrasjonar,
taleanrop eller videokonferanse."; keep the rest of the sentence unchanged and
ensure the JSON remains valid (proper quotes and commas) after editing.
In `@app/lib/services/connect.ts`:
- Around line 238-239: The deprecated "user-status" handler currently assumes
the server payload order by destructuring userStatus into [id, , status,
statusText, statusSource, statusExpiresAt]; instead, validate that userStatus is
an array and defensively read indexes (fallback to undefined/defaults) before
assigning into _activeUsers.activeUsers, using STATUSES lookup only when status
exists; mirror the safe parsing used in the stream-user-presence handler (check
length, coerce types, and treat missing statusText/statusSource/statusExpiresAt
as optional) so older RC 4.1+ servers that omit new fields won't corrupt the
active user map.
In `@app/views/RoomInfoView/components/RoomInfoViewTitle.tsx`:
- Around line 77-84: The code calls formatStatusExpiry(statusExpiresAt) twice;
compute it once into a local variable (e.g., const formattedExpiry =
formatStatusExpiry(statusExpiresAt)) near the top of RoomInfoViewTitle (or
inside the render/component function), then use formattedExpiry in the
conditional (!!statusExpiresAt && !!formattedExpiry) and inside the JSX Text
node instead of calling formatStatusExpiry again; this removes redundant
computation while keeping the same behavior.
---
Nitpick comments:
In `@app/containers/RoomHeader/RoomHeader.tsx`:
- Around line 119-126: The inline style { marginRight: 4 } on the CustomIcon in
RoomHeader.tsx should be moved into the component's StyleSheet to avoid creating
a new object each render; add a new style (e.g., iconSpacing or clockIcon) to
the existing styles created with StyleSheet.create and include marginRight: 4
there, then replace style={{ marginRight: 4 }} on the CustomIcon with
style={styles.iconSpacing} (keeping the existing styles.titleContainer reference
intact).
In `@app/lib/methods/helpers/formatStatusExpiry.ts`:
- Around line 6-12: The function currently calls dayjs() twice (once in the
expiresAt.isAfter(dayjs()) check and again when assigning now), causing
inconsistency; compute now once at the start (e.g., const now = dayjs()) and use
that same now in the isAfter check and in the isSame(now, 'day') comparison so
both validations reference the identical timestamp (update references to
expiresAt.isAfter(now) and expiresAt.isSame(now, 'day')).
- Line 16: The return currently calls expiresAt.format twice; update
formatStatusExpiry to call expiresAt.format once by combining the date and time
pattern (e.g. 'MMM D, h:mm A') and use that single formatted string in the
template; refer to the expiresAt variable and the formatStatusExpiry function to
locate and change the expression accordingly.
In `@app/views/StatusView/ClearAfterPicker.tsx`:
- Around line 166-172: getDisplayLabel currently assumes customDate exists when
value === 'custom' and falls back to CLEAR_AFTER_OPTIONS lookup if it doesn't;
add a defensive branch at the top of getDisplayLabel to handle the edge case
where value === 'custom' but customDate is null/undefined by returning a safe
fallback (e.g., I18n.t('Status_dont_clear') or another appropriate label) so the
function never attempts to call toLocaleString on a null customDate; reference
getDisplayLabel, value, customDate, CLEAR_AFTER_OPTIONS and I18n.t when making
the change.
In `@app/views/StatusView/index.tsx`:
- Around line 117-118: Extract the magic version string '8.6.0' into a named
constant (e.g., STATUS_EXPIRY_MIN_VERSION) and use that constant in the
compareServerVersion call that sets supportsStatusExpiry; update the declaration
around serverVersion, supportsStatusExpiry and compareServerVersion usages so
they reference STATUS_EXPIRY_MIN_VERSION instead of the literal string to
improve readability and maintainability.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 08ab0ff8-0004-4a51-809b-2a50101339eb
📒 Files selected for processing (44)
app/containers/RoomHeader/RoomHeader.tsxapp/containers/RoomHeader/index.tsxapp/definitions/ILoggedUser.tsapp/definitions/TStatusSource.tsapp/definitions/index.tsapp/definitions/rest/v1/users.tsapp/i18n/locales/ar.jsonapp/i18n/locales/bn-IN.jsonapp/i18n/locales/cs.jsonapp/i18n/locales/de.jsonapp/i18n/locales/en.jsonapp/i18n/locales/es.jsonapp/i18n/locales/fi.jsonapp/i18n/locales/fr.jsonapp/i18n/locales/hi-IN.jsonapp/i18n/locales/hu.jsonapp/i18n/locales/it.jsonapp/i18n/locales/ja.jsonapp/i18n/locales/nl.jsonapp/i18n/locales/nn.jsonapp/i18n/locales/no.jsonapp/i18n/locales/pt-BR.jsonapp/i18n/locales/pt-PT.jsonapp/i18n/locales/ru.jsonapp/i18n/locales/sl-SI.jsonapp/i18n/locales/sv.jsonapp/i18n/locales/ta-IN.jsonapp/i18n/locales/te-IN.jsonapp/i18n/locales/tr.jsonapp/i18n/locales/zh-CN.jsonapp/lib/methods/getUsersPresence.tsapp/lib/methods/helpers/formatStatusExpiry.test.tsapp/lib/methods/helpers/formatStatusExpiry.tsapp/lib/methods/setUser.tsapp/lib/services/connect.tsapp/lib/services/restApi.tsapp/reducers/activeUsers.tsapp/views/RoomActionsView/index.tsxapp/views/RoomActionsView/styles.tsapp/views/RoomInfoView/components/RoomInfoViewTitle.tsxapp/views/RoomInfoView/index.tsxapp/views/RoomInfoView/styles.tsapp/views/StatusView/ClearAfterPicker.tsxapp/views/StatusView/index.tsx
📜 Review details
🧰 Additional context used
📓 Path-based instructions (11)
**/*.{js,ts,jsx,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions
Files:
app/definitions/index.tsapp/definitions/rest/v1/users.tsapp/reducers/activeUsers.tsapp/definitions/TStatusSource.tsapp/containers/RoomHeader/RoomHeader.tsxapp/lib/methods/helpers/formatStatusExpiry.test.tsapp/lib/services/restApi.tsapp/views/RoomActionsView/styles.tsapp/lib/methods/setUser.tsapp/lib/methods/helpers/formatStatusExpiry.tsapp/views/RoomInfoView/index.tsxapp/lib/services/connect.tsapp/definitions/ILoggedUser.tsapp/views/RoomInfoView/styles.tsapp/containers/RoomHeader/index.tsxapp/views/RoomInfoView/components/RoomInfoViewTitle.tsxapp/lib/methods/getUsersPresence.tsapp/views/StatusView/ClearAfterPicker.tsxapp/views/StatusView/index.tsxapp/views/RoomActionsView/index.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbersUse TypeScript with strict mode enabled
Files:
app/definitions/index.tsapp/definitions/rest/v1/users.tsapp/reducers/activeUsers.tsapp/definitions/TStatusSource.tsapp/containers/RoomHeader/RoomHeader.tsxapp/lib/methods/helpers/formatStatusExpiry.test.tsapp/lib/services/restApi.tsapp/views/RoomActionsView/styles.tsapp/lib/methods/setUser.tsapp/lib/methods/helpers/formatStatusExpiry.tsapp/views/RoomInfoView/index.tsxapp/lib/services/connect.tsapp/definitions/ILoggedUser.tsapp/views/RoomInfoView/styles.tsapp/containers/RoomHeader/index.tsxapp/views/RoomInfoView/components/RoomInfoViewTitle.tsxapp/lib/methods/getUsersPresence.tsapp/views/StatusView/ClearAfterPicker.tsxapp/views/StatusView/index.tsxapp/views/RoomActionsView/index.tsx
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (CLAUDE.md)
Use Prettier formatting with tabs, single quotes, 130 character line width, no trailing commas, and avoid arrow function parentheses
Files:
app/definitions/index.tsapp/definitions/rest/v1/users.tsapp/i18n/locales/sl-SI.jsonapp/reducers/activeUsers.tsapp/i18n/locales/cs.jsonapp/i18n/locales/nn.jsonapp/i18n/locales/no.jsonapp/i18n/locales/nl.jsonapp/definitions/TStatusSource.tsapp/i18n/locales/te-IN.jsonapp/i18n/locales/en.jsonapp/i18n/locales/bn-IN.jsonapp/i18n/locales/ru.jsonapp/containers/RoomHeader/RoomHeader.tsxapp/lib/methods/helpers/formatStatusExpiry.test.tsapp/i18n/locales/zh-CN.jsonapp/lib/services/restApi.tsapp/views/RoomActionsView/styles.tsapp/i18n/locales/hi-IN.jsonapp/i18n/locales/sv.jsonapp/lib/methods/setUser.tsapp/i18n/locales/tr.jsonapp/i18n/locales/es.jsonapp/lib/methods/helpers/formatStatusExpiry.tsapp/i18n/locales/pt-PT.jsonapp/views/RoomInfoView/index.tsxapp/lib/services/connect.tsapp/i18n/locales/ar.jsonapp/i18n/locales/fr.jsonapp/i18n/locales/hu.jsonapp/definitions/ILoggedUser.tsapp/views/RoomInfoView/styles.tsapp/i18n/locales/ja.jsonapp/i18n/locales/fi.jsonapp/i18n/locales/it.jsonapp/i18n/locales/de.jsonapp/i18n/locales/ta-IN.jsonapp/containers/RoomHeader/index.tsxapp/i18n/locales/pt-BR.jsonapp/views/RoomInfoView/components/RoomInfoViewTitle.tsxapp/lib/methods/getUsersPresence.tsapp/views/StatusView/ClearAfterPicker.tsxapp/views/StatusView/index.tsxapp/views/RoomActionsView/index.tsx
**/*.{js,jsx,ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Enforce ESLint rules from
@rocket.chat/eslint-configwith React, React Native, TypeScript, and Jest plugins
Files:
app/definitions/index.tsapp/definitions/rest/v1/users.tsapp/reducers/activeUsers.tsapp/definitions/TStatusSource.tsapp/containers/RoomHeader/RoomHeader.tsxapp/lib/methods/helpers/formatStatusExpiry.test.tsapp/lib/services/restApi.tsapp/views/RoomActionsView/styles.tsapp/lib/methods/setUser.tsapp/lib/methods/helpers/formatStatusExpiry.tsapp/views/RoomInfoView/index.tsxapp/lib/services/connect.tsapp/definitions/ILoggedUser.tsapp/views/RoomInfoView/styles.tsapp/containers/RoomHeader/index.tsxapp/views/RoomInfoView/components/RoomInfoViewTitle.tsxapp/lib/methods/getUsersPresence.tsapp/views/StatusView/ClearAfterPicker.tsxapp/views/StatusView/index.tsxapp/views/RoomActionsView/index.tsx
app/definitions/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Place shared TypeScript type definitions in 'app/definitions/' directory
Files:
app/definitions/index.tsapp/definitions/rest/v1/users.tsapp/definitions/TStatusSource.tsapp/definitions/ILoggedUser.ts
app/i18n/**/*.{ts,tsx,json}
📄 CodeRabbit inference engine (CLAUDE.md)
Place internationalization (i18n) configuration in 'app/i18n/' directory with support for 40+ locales and RTL
Files:
app/i18n/locales/sl-SI.jsonapp/i18n/locales/cs.jsonapp/i18n/locales/nn.jsonapp/i18n/locales/no.jsonapp/i18n/locales/nl.jsonapp/i18n/locales/te-IN.jsonapp/i18n/locales/en.jsonapp/i18n/locales/bn-IN.jsonapp/i18n/locales/ru.jsonapp/i18n/locales/zh-CN.jsonapp/i18n/locales/hi-IN.jsonapp/i18n/locales/sv.jsonapp/i18n/locales/tr.jsonapp/i18n/locales/es.jsonapp/i18n/locales/pt-PT.jsonapp/i18n/locales/ar.jsonapp/i18n/locales/fr.jsonapp/i18n/locales/hu.jsonapp/i18n/locales/ja.jsonapp/i18n/locales/fi.jsonapp/i18n/locales/it.jsonapp/i18n/locales/de.jsonapp/i18n/locales/ta-IN.jsonapp/i18n/locales/pt-BR.json
app/reducers/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Place reducers in 'app/reducers/' directory
Files:
app/reducers/activeUsers.ts
app/containers/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Place reusable UI components in 'app/containers/' directory
Files:
app/containers/RoomHeader/RoomHeader.tsxapp/containers/RoomHeader/index.tsx
app/lib/services/restApi.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Use 'app/lib/services/restApi.ts' for HTTP requests via fetch
Files:
app/lib/services/restApi.ts
app/views/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Place screen components in 'app/views/' directory
Files:
app/views/RoomActionsView/styles.tsapp/views/RoomInfoView/index.tsxapp/views/RoomInfoView/styles.tsapp/views/RoomInfoView/components/RoomInfoViewTitle.tsxapp/views/StatusView/ClearAfterPicker.tsxapp/views/StatusView/index.tsxapp/views/RoomActionsView/index.tsx
app/lib/services/connect.ts
📄 CodeRabbit inference engine (CLAUDE.md)
Use 'app/lib/services/connect.ts' for server connection management
Files:
app/lib/services/connect.ts
🧠 Learnings (1)
📚 Learning: 2026-04-30T17:07:51.020Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7274
File: app/lib/services/voip/MediaCallEvents.ts:0-0
Timestamp: 2026-04-30T17:07:51.020Z
Learning: In this Rocket.Chat React Native codebase, the ESLint rule `no-void: error` is enforced. When you see a promise returned from an async call that is not awaited (a “floating promise”), do not silence it with the `void somePromise()` pattern. Instead, handle the promise explicitly by attaching `.catch(...)` (or otherwise awaiting/handling the error) so unhandled-rejection risks are addressed in a way that satisfies the existing ESLint configuration.
Applied to files:
app/definitions/index.tsapp/definitions/rest/v1/users.tsapp/reducers/activeUsers.tsapp/definitions/TStatusSource.tsapp/containers/RoomHeader/RoomHeader.tsxapp/lib/methods/helpers/formatStatusExpiry.test.tsapp/lib/services/restApi.tsapp/views/RoomActionsView/styles.tsapp/lib/methods/setUser.tsapp/lib/methods/helpers/formatStatusExpiry.tsapp/views/RoomInfoView/index.tsxapp/lib/services/connect.tsapp/definitions/ILoggedUser.tsapp/views/RoomInfoView/styles.tsapp/containers/RoomHeader/index.tsxapp/views/RoomInfoView/components/RoomInfoViewTitle.tsxapp/lib/methods/getUsersPresence.tsapp/views/StatusView/ClearAfterPicker.tsxapp/views/StatusView/index.tsxapp/views/RoomActionsView/index.tsx
🔇 Additional comments (40)
app/lib/methods/getUsersPresence.ts (1)
83-89: LGTM!app/lib/services/connect.ts (2)
243-243: LGTM!
205-206: Hardenstream-user-presencepayload parsing inapp/lib/services/connect.ts(tuple order/version compatibility).
app/lib/services/connect.ts(lines 205-206) destructuresuserStatusas[, status, statusText, statusSource, statusExpiresAt], which is position-dependent and assumes the server always sends those fields in that exact order and always includesstatusSource/statusExpiresAt. If the server payload differs or fields are missing on older versions, the client may map wrong values.Add runtime guards/defaults (and/or a server-version gate) and confirm from the server-side
stream-user-presencecontract/tests that this tuple ordering is stable across all supported server versions.app/containers/RoomHeader/RoomHeader.tsx (3)
12-12: LGTM!
55-55: LGTM!Also applies to: 71-71, 93-93
152-152: LGTM!Also applies to: 246-246
app/containers/RoomHeader/index.tsx (1)
48-48: LGTM!Also applies to: 69-71, 84-84
app/lib/methods/helpers/formatStatusExpiry.test.ts (1)
1-41: LGTM!app/views/RoomInfoView/index.tsx (1)
291-308: LGTM!app/views/RoomInfoView/styles.ts (1)
102-106: LGTM!app/views/RoomActionsView/index.tsx (1)
779-826: LGTM!app/views/RoomActionsView/styles.ts (1)
34-39: LGTM!app/definitions/TStatusSource.ts (1)
1-1: LGTM!app/definitions/index.ts (1)
40-40: LGTM!app/definitions/ILoggedUser.ts (1)
4-4: LGTM!Also applies to: 14-17
app/definitions/rest/v1/users.ts (1)
38-38: LGTM!app/reducers/activeUsers.ts (1)
2-2: LGTM!Also applies to: 4-10
app/views/StatusView/ClearAfterPicker.tsx (4)
23-29: LGTM!
56-85: LGTM!
87-154: LGTM!
162-194: LGTM!app/views/StatusView/index.tsx (4)
134-150: LGTM!
168-185: LGTM!
189-200: LGTM!
202-219: LGTM!app/lib/methods/setUser.ts (1)
56-59: Potentially drops additional status metadata from_setUserDDP updates
IActiveUsersincludesstatusText,statusExpiresAt, andstatusSource, but this handler only writes{ status: ... }fromddpMessage.fields.status(lines 56-59), so those optional fields are left unset.- The DDP client treats
ddpMessage.fieldsas a generic payload map, so if the server sendsstatusText/statusExpiresAt/statusSourcein this message, they would be present inddpMessage.fieldsand currently discarded.- Confirm whether
_setUserreceives those keys inddpMessage.fields; if it does, map/spread them into_activeUsers.activeUsers[ddpMessage.id]instead of status-only assignment.app/lib/services/restApi.ts (1)
332-339: LGTM!app/i18n/locales/ar.json (1)
592-597: LGTM!app/i18n/locales/bn-IN.json (1)
798-803: LGTM!app/i18n/locales/cs.json (1)
857-862: LGTM!app/i18n/locales/de.json (1)
794-799: LGTM!app/i18n/locales/pt-BR.json (1)
867-872: LGTM!app/i18n/locales/pt-PT.json (1)
516-521: LGTM!app/i18n/locales/ru.json (1)
746-751: LGTM!app/i18n/locales/sl-SI.json (1)
722-727: LGTM!app/i18n/locales/sv.json (1)
768-773: LGTM!app/i18n/locales/ta-IN.json (1)
798-803: LGTM!app/i18n/locales/te-IN.json (1)
797-802: LGTM!app/i18n/locales/tr.json (1)
608-613: LGTM!app/i18n/locales/zh-CN.json (1)
581-586: LGTM!
Rohit3523
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
Rohit3523
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
Rohit3523
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
Rohit3523
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
Rohit3523
had a problem deploying
to
approve_e2e_testing
GitHub Actions
Error
|
iOS Build Available Rocket.Chat 4.74.0.109139 |
Rohit3523
commented
Jun 18, 2026
Rohit3523
commented
Jun 18, 2026
|
Android Build Available Rocket.Chat 4.74.0.109142 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNTPKI33pd1E8_uEb-44YlVJ2rKb6qtBbBzRXeFIaSIlCho-GQt-qlIRVYCD8mQcB-ops_omEkZ4yRwlYTlo |
|
iOS Build Available Rocket.Chat 4.74.0.109143 |
|
iOS Build Available Rocket.Chat 4.74.0.109157 |
|
Android Build Available Rocket.Chat 4.74.0.109156 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNQOHvkn8edvUlXnnYMejx80zjIdVD6ide4kkZUrwExiA6Y3OTq_Eiyc4E4ptC9jWRE5kKmeUX6yKXJeHobl |
diegolmello
requested changes
Jun 19, 2026
|
Android Build Available Rocket.Chat 4.74.0.109161 Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSoeCgnmapvf9krwS6wNWvUf4L6TxPHLXLW1vUIwG2rJNyNpVQXIzOayqipjpvKkjR_b7XcGBxzW1B5R5Ud |
|
iOS Build Available Rocket.Chat 4.74.0.109162 |
diegolmello
requested changes
Jun 19, 2026
Member
There was a problem hiding this comment.
The more I look at this file, more I find new functions and components 🙈
Organize the 🍝 and the code is going to look better
| (state: IApplicationState) => state.settings.Accounts_AllowInvisibleStatusOption | ||
| ); | ||
| const serverVersion = useSelector((state: IApplicationState) => state.server.version); | ||
| const supportsStatusExpiry = compareServerVersion(serverVersion, 'greaterThanOrEqualTo', '8.6.0'); |
Member
There was a problem hiding this comment.
You're running this on every re-render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds support for temporary/expiring custom status messages. Users can now set a status that automatically clears after a chosen duration (30 minutes, 1 hour, or a custom date/time). When a status has an expiry, a clock icon and "Until" timestamp are shown next to the status in the room header, room actions, and room info views for direct messages.
This feature requires server version 8.6.0+.
On workspaces running 8.6.0+, users can no longer manually set their status to "Away" — it is handled automatically by the server. The Away option is hidden from the Status screen unless the user is already in that state.
Key changes:
ClearAfterPickercomponent in StatusView for selecting expiry durationformatStatusExpiryhelper to display formatted expiry timestampsnormalizeStatusExpiresAthelper to handle EJSON and ISO date formatsstream-user-presence,user-status) updated to processstatusExpiresAtandstatusSourcefieldsusers.setStatusREST API now sendsexpiresAtwhen setILoggedUser,IActiveUser,TStatusSourceIssue(s)
https://rocketchat.atlassian.net/browse/PRES-39
How to test or reproduce
Screenshots
Setting expiring status
Screen.Recording.2026-06-16.at.10.05.18.PM.mov
Screen.Recording.2026-06-16.at.10.28.48.PM.mov
Realtime status update
Room header
Screen.Recording.2026-06-16.at.10.17.00.PM.mov
Room Action
Screen.Recording.2026-06-16.at.10.18.55.PM.mov
User info
Screen.Recording.2026-06-16.at.10.26.22.PM.mov
Types of changes
Checklist
Further comments
Summary by CodeRabbit
Summary