chore: remove unused react-native-config-reader#7377
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
WalkthroughThis PR removes the ChangesDependency Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The only consumer was `isOfficial = RNConfigReader.IS_OFFICIAL`, deleted in #7322 (remove Experimental code paths) along with the `official` product flavor that produced the `IS_OFFICIAL` BuildConfig field (#7325). Since then the package has had zero JS imports — it was autolinked dead weight. Removes: - the dependency and its @types - the ambient `declare module` in externalModules.d.ts - the orphaned iOS podspec patch (patch-package was erroring on it) - the `rn_config_reader_custom_package` resValue in build.gradle, which only the now-removed native module read Verified: pnpm install + patch-package clean, tsc passes.
8867c32 to
77ab4f9
Compare
Proposed changes
Removes the unused
react-native-config-readerdependency.Its only ever consumer was
isOfficial = RNConfigReader.IS_OFFICIAL, deleted in #7322 (remove Experimental code paths) along with theofficialproduct flavor that produced theIS_OFFICIALBuildConfig field (#7325). Since then the package has had zero JS imports — it remained only as an autolinked native module reading BuildConfig values that nothing consumes.While here, this also removes:
patches/react-native-config-reader+4.1.1.patch—patch-packagewas erroring on it (patch-package finished with 1 error(s)) on a clean installrn_config_reader_custom_packageresValue inandroid/app/build.gradle, read only by the now-removed native module (and one of only two remaining references to the legacychat.rocket.reactnativenamespace)RNConfigReaderpod fromios/Podfile.lock(regenerated viapod install)Surfaced while investigating the
pnpm androidlaunch fix (#7375).Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-1223
How to test or reproduce
pnpm install— completes with nopatch-packageerrors (previously errored on the orphanedreact-native-config-readerpatch).pnpm pod-install— regeneratesios/Podfile.lockwithRNConfigReaderremoved (already committed here; re-running is a no-op).tscpasses (verified locally).Screenshots
N/A
Types of changes
Checklist
Further comments
Dead-code removal only; no runtime behavior change since the module had no JS consumers after #7322 / #7325. Independent of the run-script fix (#7375) and the larger Android namespace-rename discussion. Touches native build inputs (Android
build.gradle, iOSPodfile.lock), so an Android + iOS build/launch smoke check is warranted before merge.Summary by CodeRabbit