Lighting & Shaders Improvements#20
Closed
raphydaphy wants to merge 12 commits intoRockBottomGame:masterfrom
Closed
Lighting & Shaders Improvements#20raphydaphy wants to merge 12 commits intoRockBottomGame:masterfrom
raphydaphy wants to merge 12 commits intoRockBottomGame:masterfrom
Conversation
canitzp
changed the title
raphydaphy
changed the title
Quarris
requested changes
Aug 14, 2019
| @@ -147,7 +147,7 @@ public void draw(float x, float y) { | |||
|
|
|||
| @Override | |||
| public void draw(float x, float y, float scale) { | |||
Member
There was a problem hiding this comment.
Is the scale necessary to have in this method at this point then?
|
|
||
| public void render(IGameInstance game, IAssetManager manager, ParticleManager particles, IRenderer g, AbstractWorld world, EntityPlayer player, InteractionManager input) { | ||
| float scale = g.getWorldScale(); | ||
| calcCameraValues(manager, g); |
|
|
||
| public float getTranslucentModifier(IWorld world, int x, int y, TileLayer layer, boolean skylight) { | ||
| if (world.getState(layer, x, y).get(StaticTileProps.LOG_VARIANT).isNatural()) | ||
| return skylight ? 1F : layer == TileLayer.BACKGROUND ? 0.9f : 0.8f; |
Member
Author
There was a problem hiding this comment.
u literally watched me type this but ok
Member
There was a problem hiding this comment.
yes, and both myself and ellpeck clearly laughed at you and said to change it :P
Collaborator
|
merge this, it is good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made several improvements to lighting and shaders
Also check the API and Assets PR's.