v2 README docs, static analysis CI, expanded tests, and non-finite wire fixes#6
Merged
Conversation
Run cppcheck and clang-tidy on Ubuntu via smallfolk_static_analysis targets, with optional SMALLFOLK_ENABLE_CLANG_TIDY for build-time checks. Add tests for setignore, nil semantics, copy depth, insert/remove, load limit globals, path errors, schema one_of initializer_list, validation depth limits, and loads_validated limit overloads.
Ensure non-finite values always serialize as N/Q/I/i tokens instead of nan/inf text that the parser misreads as nil, and add fixed gvx wire fixtures for cross-implementation checks.
Use fpclassify and snprintf fallbacks so NaN/Inf never stream as nan/inf text, and construct non-finite test values with numeric_limits instead of 0/0.
Map libc nan/inf text to N/Q/I/i like the original serializer instead of mis-encoding unrecognized NaN strings as +inf on glibc.
Match gvx Smallfolk NaN dump via tostring sign, parse N/Q with runtime 0/0 like Lua, check isnan before isfinite when encoding, and suppress intentional cppcheck findings on the header-library API.
Drop cppcheck style checks that fail on the public LuaVal API, assert exact non-finite wire tokens, and use isnan-safe comparisons in tests.
Stop treating all clang-tidy warnings as errors on legacy library sources, parse N/Q via std::nan, and rely on round-trip isnan checks instead of exact wire bytes that vary by libc NaN formatting.
Keep nested array schemas in static storage so CompiledSchema does not bind to a destroyed temporary, which caused validation to spuriously pass on Linux/macOS.
Rochet2
changed the title
Record README and static-analysis additions, Linux/macOS non-finite wire fix, and expanded test coverage pending the next release tag.
Rename the unreleased section to 2.0.1 (2026-05-31) and align CMake/README version strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SMALLFOLK_BUILD_TESTStypo, linkCHANGELOG.md, and document v2 APIs (safe lookup, path API,loads_or_throw/dumps_or_throw, typed accessors,lua_valfactories, static analysis usage)..clang-tidy,cmake/StaticAnalysis.cmake,cppcheck-suppressions.txt, and an Ubuntu CI job running cppcheck + clang-tidy.test_smallfolk.cppandtest_schema.cpp(nil/setignore/copy/insert/remove, path errors, schema depth limits, etc.) and add fixed gvx/Lua Smallfolk wire interop fixtures intest_lua_smallfolk_interop_wires().N/Q/I/i) so glibc/libstdc++ round-trips correctly on Linux/macOS; parsenantext and usestd::nanforN/Qtokens.smallfolk.handsmallfolk.cpp.Test plan
smallfolk_tests— non-finite round-trip and Lua wire interop fixturessmallfolk_schema_tests— depth-limit validation on GCC