Fix building with MSVC & reduce the amount of warnings in general#393
Merged
Conversation
Contributor
Author
|
As you can also seems to build fine with gcc/clang. Cant confirm myself though. |
Contributor
Author
penggrin12
commented
May 10, 2026
Comment on lines
-81
to
83
| #define RAYLIB_ASSERT_CAT( A, B ) A ## B | ||
| #define RAYLIB_ASSERT_SELECT( NAME, NUM ) RAYLIB_ASSERT_CAT( NAME ## _, NUM ) | ||
| #define RAYLIB_ASSERT_CAT(a, b) RAYLIB_ASSERT_CAT_I(a, b) | ||
| #define RAYLIB_ASSERT_CAT_I(a, b) a##b | ||
| #define RAYLIB_ASSERT_SELECT(name, num) RAYLIB_ASSERT_CAT(name##_, num) | ||
| #define RAYLIB_ASSERT_GET_COUNT( _1, _2, _3, _4, _5, _6, _7, RAYLIB_ASSERT_COUNT, ... ) RAYLIB_ASSERT_COUNT |
Contributor
Author
There was a problem hiding this comment.
This should also be changed upstream in raylib-assert
Contributor
Author
|
Windows workflows also now build, but i couldn't get them to test. Will make a follow up PR for the workflows after this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds for me with Rider's default stuff for Visual Studio 2022 tools.