Skip to content

list_view: dynamic height #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobLoach merged 2 commits into from
Jun 15, 2026
+18 −7
Merged

list_view: dynamic height #263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bf2cb2
list_view: dynamic height when rows_visible is 0
RobLoach Jun 15, 2026
303fac7
Update size
RobLoach Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions demo/common/nuklear_console_demo.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,12 +390,12 @@ struct nk_console* nuklear_console_demo_init(struct nk_context* ctx, void* user_
}

// Add the List View
struct nk_console* list_view = nk_console_list_view(list_view_button, "The List View", 10, NK_CONSOLE_DEMO_LIST_VIEW_COUNT, &list_view_event_get_label);
struct nk_console* list_view = nk_console_list_view(list_view_button, "The List View", 0, NK_CONSOLE_DEMO_LIST_VIEW_COUNT, &list_view_event_get_label);
nk_console_add_event(list_view, NK_CONSOLE_EVENT_CLICKED, &nk_console_demo_list_view_item_clicked);
nk_console_list_view_set_searchable(list_view, nk_true);

// Back button
nk_console_button_onclick(list_view_button, "Back", &nk_console_button_back);
//nk_console_button_onclick(list_view_button, "Back", &nk_console_button_back);
}

// Progress Bar
Expand Down
21 changes: 16 additions & 5 deletions nuklear_console_list_view.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ extern "C" {
*
* @param parent Where the element should be placed.
* @param id A unique identifier for the list view.
* @param rows_visible The number of rows to be shown at any given time.
* @param rows_visible The number of rows to be shown at any given time. Pass 0 to fill the remaining window height.
* @param item_count The number of items in the data set.
* @param get_label_callback The callback that will be used to retrieve individual labels.
*
Expand Down Expand Up @@ -354,7 +354,18 @@ NK_API struct nk_rect nk_console_list_view_render(nk_console* widget) {

// Layout the widget with the correct visible height so widget_bounds is accurate.
struct nk_rect widget_bounds = nk_layout_widget_bounds(top->ctx);
widget_bounds.h = row_height * (float)data->rows_visible;
nk_uint rows_visible = data->rows_visible;
if (rows_visible == 0) {
struct nk_rect content = nk_window_get_content_region(top->ctx);
// Leave the same padding gap at the bottom that the window reserves at the
// top (top padding is already baked into widget_bounds.y via at_y).
float remaining = (content.y + content.h) - widget_bounds.y - top->ctx->style.window.padding.y;
// Use a signed intermediate: casting a negative float to nk_uint is UB and
// would slip past the < 1 clamp as a huge value.
int fit = (int)(remaining / scroll_row_height);
rows_visible = fit < 1 ? (nk_uint)1 : (nk_uint)fit - 1;
}
widget_bounds.h = scroll_row_height * (float)rows_visible;

if (widget->disabled) {
nk_widget_disable_begin(top->ctx);
Expand Down Expand Up @@ -385,7 +396,7 @@ NK_API struct nk_rect nk_console_list_view_render(nk_console* widget) {
if (nk_console_button_pushed(top, NK_GAMEPAD_BUTTON_LB) || nk_input_is_key_pressed(&top->ctx->input, NK_KEY_SCROLL_UP)) {
// Page up: jump selection up by rows_visible items (in display space).
if (sel_disp > 0) {
nk_uint new_disp = (nk_uint)NK_MAX(0, (int)sel_disp - (int)data->rows_visible);
nk_uint new_disp = (nk_uint)NK_MAX(0, (int)sel_disp - (int)rows_visible);
data->selected = nk_console_list_view_nth_match(widget, data, new_disp, filter);
sel_disp = new_disp;
nk_console_list_view_apply_scroll(data, sel_disp * (nk_uint)scroll_row_height);
Expand All @@ -395,7 +406,7 @@ NK_API struct nk_rect nk_console_list_view_render(nk_console* widget) {
else if (nk_console_button_pushed(top, NK_GAMEPAD_BUTTON_RB) || nk_input_is_key_pressed(&top->ctx->input, NK_KEY_SCROLL_DOWN)) {
// Page down: jump selection down by rows_visible items (in display space).
if (display_count > 0 && sel_disp < display_count - 1) {
nk_uint new_disp = NK_MIN(display_count - 1, sel_disp + data->rows_visible);
nk_uint new_disp = NK_MIN(display_count - 1, sel_disp + rows_visible);
data->selected = nk_console_list_view_nth_match(widget, data, new_disp, filter);
sel_disp = new_disp;
nk_console_list_view_scroll_into_view_down(data, sel_disp, display_count, scroll_row_height);
Expand Down Expand Up @@ -561,7 +572,7 @@ NK_API nk_console* nk_console_list_view(nk_console* parent, const char* id, int
}
nk_zero(data, sizeof(nk_console_list_view_data));
data->row_count = item_count;
data->rows_visible = rows_visible <= 0 ? (nk_uint)10 : (nk_uint)rows_visible;
data->rows_visible = rows_visible < 0 ? (nk_uint)10 : (nk_uint)rows_visible;
data->get_label_callback = get_label_callback;
data->flags = NK_WINDOW_BORDER;

Expand Down
Loading