Conversation
dvargas92495
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I just added the google contacts scope to the app. Can you share a video of using this feature within Roam? I'll need it for the verification process
| extension: { | ||
| google: { | ||
| fetchGoogleCalendar?: (options: any) => Promise<any>; | ||
| fetchGoogleContacts?: () => Promise<FormattedContact[]>; |
There was a problem hiding this comment.
@mdroidian let's follow up this PR to add it to where the rest are declared in roamjs-components, then delete from here
|
Thanks for adding the scope @dvargas92495 ! Trying to log in with the extension on my dev branch to test and I keep getting this error. Thankfully signing in with the version on Roam Depot still works. |
|
@mdroidian we will also need to make a change here to ensure we only add this query param when Edit: Agh actually, we can't rebase the latest roamjs-components until the samepage cutover is done. Let's make ^ change to the patch-package |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Working to quickly add support for Google Contacts. This would be very helpful for RoamCRM.
This PR is still a WIP because I don't have access to the Google Cloud Console for the extension.
I believe the scope
https://www.googleapis.com/auth/contacts.readonlywould need to be added for me to test.Would you be willing to add that scope?