feat(ui): remove the dead warden role from the Compass UI - #231
Open
seal-agent wants to merge 1 commit into
Open
feat(ui): remove the dead warden role from the Compass UI#231seal-agent wants to merge 1 commit into
seal-agent wants to merge 1 commit into
Conversation
Warden is dead — the role no longer exists in the product, so its role/fixture/comms/pip and the wardenPaused agent-state producer were dead code in a pre-dogfood codebase. - AgentRole union drops "warden" (supervisor | worker) - delete the acc-warden fixture, its home-DM topic + matt<->warden messages, and the .role-pip[data-role="warden"] rule - agent-state: drop the wardenPaused refinement + its `return "paused"` producer. The `paused` dot state stays (union member, token, CSS) — it is now directly-settable-only, no longer warden-derived. - tests: delete the wardenPaused override block; repoint acc-warden usages to live agents (supervisor / cook / livingstone) preserving each test's intent. Refs SEA-1892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warden is dead — the role no longer exists in the product, so its role/fixture/comms/pip and the
wardenPausedagent-state producer were dead code in a pre-dogfood codebase. This removes all of it.Refs SEA-1892. Resolves the SEA-1876 Q4 warden-purple design fork (the warden pip is deleted, so there is no warden-purple question left; the other 4
--purpleconsumers are handled in the DS token-cutover design record).Change (12 files, +40/-158, all apps/ui/src)
stub-data.ts—AgentRoleunion drops"warden"("supervisor" | "worker"); delete theacc-wardenfixture; reword a stub issue title.agent-state.ts— delete thewardenPausedrefinement + itsreturn "paused"producer.pausedstays a validAgentState(union member,--st-pausedtoken,.state-dot[data-state="paused"]CSS) per Matt's ruling — it is now directly-settable-only, no longer warden-derived.comms-stub.ts— delete the warden DM topic + 3 matt↔warden messages; reword the fleet-snapshot text. (dm-wardenchannel auto-derives fromSTUB_AGENTSand drops with the fixture.)LeftSidebar.tsx— collapse the role-pip glyph to◆(supervisor is the only remaining non-worker).app.css— delete the.role-pip[data-role="warden"]rule; reword a header comment.--purpledef + its 4 other consumers untouched.wardenPausedoverride block (tested deleted behavior); repointacc-wardenusages to live fixtures (acc-supervisorfor owns-nothing/zero-terminal intent,acc-cookfor the fleet-pane home-DM render,acc-livingstonefor the pin-order constant) preserving each test's original intent.Verification
wardenrefs remain underapps/ui/src..gitpresent (env-secrecy tests shellgit):tsc0,biome0,bun test --conditions browser= 699 pass / 0 fail (was 723 on main; the 24-test drop is exactly the deletedwardenPausedcoverage).CIcompleted/SUCCESS at headf3ce0220; merge state CLEAN/MERGEABLE.Review
Sole adversarial review: floor-clean — 0 high, 0 medium, 2 low, 2 nit. The reviewer independently confirmed every
acc-wardenrepoint preserves its test's intent, the projection totality invariant holds, and the producerless-pausedstate is Matt's intentional ruling (not a bug). The 2 nits (both terminal tests now useacc-supervisor; a comment wording tweak) are below-floor cosmetic and deliberately not committed.Open Questions (parked for Matt — non-blocking)
pausedrender path is now test-uncovered. With the warden producer gone and no fixture agent carryinglifecycle: "paused", nothing renders a paused dot, so the retained render path is covered only by theVALID_DOTSmembership guard, not an actual render. This is coherent with the keep-pausedruling; the reviewer flagged (and I agree) that adding alifecycle: "paused"fixture to keep the path exercised is a fixture/design choice for Matt, not a mechanical fix — parked rather than done unilaterally.