feat(compass-agent): SEA-1732 jj skill adapted for Compass (T8) - #226
Open
seal-agent wants to merge 4 commits into
Open
feat(compass-agent): SEA-1732 jj skill adapted for Compass (T8)#226seal-agent wants to merge 4 commits into
seal-agent wants to merge 4 commits into
Conversation
Adapts Matt's jj skill to Compass as config/skills/jj/SKILL.md (GC-7: keep invariants, re-ground mechanics). This is the riskiest adaptation of the SEA-1732 skill set, shipped as its own review cycle per the design record. Shipped at config/skills/jj/ with name: jj per DL-142 (Active, Matt 2026-08-05): Compass names the adapted skill `jj`, not the wave's `jj-stacking`, and folds stacking into the one jj skill (no separate `stacking` skill). DL-142 explicitly supersedes the frozen SEA-1732 record's `jj-stacking` naming. KEPT invariants: never push/force-push main, never merge (human operator gate), always non-interactive, review-fixes-are-a-new-commit-never-amend, the jj-new-before-edit auto-amend footgun, rebase-onto-main-before-submit, stack-aggressively-but-re-verify-each-head. RE-GROUNDED to Compass: per-agent colocated clone (jj git clone --colocate), per-worker jj workspaces for parallel task subagents, commit-message-IS-the-PR via jj-vine submit (kept as Compass's stacked-PR tool per DL-142), CI gate = the hk pre-push hook running moon ci (grounded in CONTRIBUTING.md + AGENTS.md). DESIGN GAP (flagged, not fabricated): the concrete push-authorization guard (sealed's jj-hp equivalent) is not established for Compass -- DL-142 defers the push-guard mechanism to this task but the sources do not define the command. Kept the never-push-main invariant as behavioral and marked the guard a plain-text TODO rather than inventing a wrapper. Forge PR/review-state read tools deferred as TODO SEA-1734. This gap is surfaced to Matt. GC-3: only live tools/commands named; no fabricated push command. config/skills/** is linted -- verified whole-repo markdownlint clean. Refs SEA-1732 (SEA-1758) Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
…iew low) CONTRIBUTING.md distinguishes 'moon ci' (moon's affected-aware subset the hk pre-push hook runs) from 'moon run :ci' (the whole gate). The jj skill's pre-push line named the latter with the former's parenthetical; align to 'moon ci'. Refs SEA-1732 (SEA-1758) Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
…ll (SEA-1882) Matt ruled the Compass push-authorization guard (2026-08-07): a bundled OMP extension that intercepts push/merge in-container is LOAD-BEARING, because Compass cannot rely on a user's own GitHub repo branch protection (server-side backstop only, never guaranteed). Refine the jj skill's push-guard note from an open '[TODO] not yet established' to the decided design tracked in SEA-1882; invariant stays behavioral until the extension ships. Refs SEA-1732 (SEA-1758) · SEA-1882 (the guard follow-up) Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
… the jj skill (SEA-1882) Closes the push-guard gap flagged on the original PR: the skill described the local CI gate as an `hk` pre-push hook, but jj runs no git hooks, so a native pre-push hook never fires. Name `jj-hp push` as the mechanism that runs the `hk` / `moon ci` gate then pushes, and note that `jj-vine`'s own push routes through it (`jj-vine.push`), so `jj-vine submit` is itself gated. Keeps the `jj-hp` CI gate distinct from the push-*authorization* guard (never-push-main / owner-allowlist), which remains a separate `[TODO SEA-1882]` OMP extension — the two mechanisms are not the same, and the earlier text conflated them. Adds a `jj-hp push` row to the command reference. Refs SEA-1732 (SEA-1758) Co-authored-by: Matt Wilkinson <matt@sealedsecurity.com>
seal-agent
force-pushed
the
seal-1732-jj-skill
branch
from
August 8, 2026 00:26
0e3c64e to
461a340
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts Matt's jj skill to Compass as config/skills/jj/SKILL.md (GC-7: keep
invariants, re-ground mechanics). This is the riskiest adaptation of the SEA-1732
skill set, shipped as its own review cycle per the design record.
Shipped at config/skills/jj/ with name: jj per DL-142 (Active, Matt 2026-08-05):
Compass names the adapted skill
jj, not the wave'sjj-stacking, and foldsstacking into the one jj skill (no separate
stackingskill). DL-142 explicitlysupersedes the frozen SEA-1732 record's
jj-stackingnaming.KEPT invariants: never push/force-push main, never merge (human operator gate),
always non-interactive, review-fixes-are-a-new-commit-never-amend, the
jj-new-before-edit auto-amend footgun, rebase-onto-main-before-submit,
stack-aggressively-but-re-verify-each-head. RE-GROUNDED to Compass: per-agent
colocated clone (jj git clone --colocate), per-worker jj workspaces for parallel
task subagents, commit-message-IS-the-PR via jj-vine submit (kept as Compass's
stacked-PR tool per DL-142), CI gate = the hk pre-push hook running moon ci
(grounded in CONTRIBUTING.md + AGENTS.md).
DESIGN GAP (flagged, not fabricated): the concrete push-authorization guard
(sealed's jj-hp equivalent) is not established for Compass -- DL-142 defers the
push-guard mechanism to this task but the sources do not define the command.
Kept the never-push-main invariant as behavioral and marked the guard a
plain-text TODO rather than inventing a wrapper. Forge PR/review-state read tools
deferred as TODO SEA-1734. This gap is surfaced to Matt.
GC-3: only live tools/commands named; no fabricated push command. config/skills/**
is linted -- verified whole-repo markdownlint clean.
Refs SEA-1732 (SEA-1758)
Co-authored-by: Matt Wilkinson matt@sealedsecurity.com