Improve accuracy of transactions origin Part 4: Post remaining transaction metadata when syncing purchases

[tonidero]

Description

Follow-up on #2989

This handles a possible edge case where a transaction is not returned by the store anymore. In this scenario, we still want to post any remaining cached metadata. This handles that by syncing all remaining metadata after any remaining purchases from the queue.

[codecov]

Codecov Report

❌ Patch coverage is 82.05128% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.02%. Comparing base (11f29c0) to head (0b31bfa).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...enuecat/purchases/PostPendingTransactionsHelper.kt	57.89%	1 Missing and 7 partials ⚠️
...tlin/com/revenuecat/purchases/PostReceiptHelper.kt	91.07%	2 Missing and 3 partials ⚠️
...es/common/caching/LocalTransactionMetadataStore.kt	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2993      +/-   ##
==========================================
+ Coverage   78.99%   79.02%   +0.03%     
==========================================
  Files         341      341              
  Lines       13500    13566      +66     
  Branches     1825     1839      +14     
==========================================
+ Hits        10664    10721      +57     
- Misses       2078     2079       +1     
- Partials      758      766       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tonidero]

I ended up doing a total refactor by moving most logic from the PostPendingTransactionHelper to the PostReceiptHelper in be50f92. Might be worth start reviewing from scratch TBH 😅 @RevenueCat/coresdk

[Copilot]

Pull request overview

This PR addresses an edge case where cached transaction metadata may not be synced if the associated transaction is no longer returned by the Play Store. It adds functionality to post any remaining cached transaction metadata after syncing regular purchases.

Changes:

• Added getAllLocalTransactionMetadata() method to retrieve all cached transaction metadata
• Implemented postRemainingCachedTransactionMetadata() to sync cached metadata not associated with active transactions
• Integrated metadata syncing into the purchase queue sync flow to run after regular transaction processing
• Renamed TransactionMetadata.userID field to appUserID for consistency (preserving serialization compatibility)

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
LocalTransactionMetadata.kt	Renamed field from userID to appUserID for naming consistency while preserving JSON serialization compatibility
LocalTransactionMetadataStore.kt	Added getAllLocalTransactionMetadata() method to retrieve all cached metadata
PostReceiptHelper.kt	Implemented postRemainingCachedTransactionMetadata() and extracted shared logic into performPostReceipt()
PostPendingTransactionsHelper.kt	Integrated cached metadata posting after regular transaction sync in all completion paths
PurchasesFactory.kt	Updated dependency injection to pass postReceiptHelper to PostPendingTransactionsHelper
LocalTransactionMetadataStoreTest.kt	Added comprehensive tests for getAllLocalTransactionMetadata() and updated field references
PostReceiptHelperTest.kt	Added tests for postRemainingCachedTransactionMetadata() covering various scenarios including success, errors, and multiple transactions
PostPendingTransactionsHelperTest.kt	Added integration tests for cached metadata posting in different sync scenarios
SubscriberAttributesPurchasesTests.kt	Updated mock setup to include new dependencies

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[JayShortway]

Nice one! Just a suggestion.

[rickvdl]

Looks great! And thanks for all the iterations 🙌