Keep foresters off potential farm fields

[DevOpsOfChaos]

Summary

This adds an optional gameplay addon for farm/forester interaction.

When the addon is enabled, foresters no longer plant trees on spots that a completed own farm could currently use as a new grain field.

The default gameplay behavior is unchanged because the addon is disabled by default.

The change is intentionally narrow:

• it only affects forester planting target selection when the addon is enabled
• it only protects potential new grain field spots for the same player
• it mirrors the existing farmer field-placement constraints
• it does not reserve farm land globally
• it does not change how farmers place fields
• it does not change how foresters plant outside potential farm field spots
• it does not affect enemy farms or cross-player land usage

Motivation

Foresters can currently plant trees on otherwise valid farm field spots before the farmer gets to them.

This can be annoying in normal play because a forester may occupy land that a nearby farm could otherwise use productively. However, this is also part of the original gameplay feel for some players, since foresters blocking useful spots is expected behavior in classic play.

For that reason, this PR no longer changes the default behavior directly. Instead, the behavior is now optional through a new addon.

Implementation details

This PR adds a new addon:

• AddonForesterFarmFieldAvoidance
• AddonId::FORESTER_FARM_FIELD_AVOIDANCE = 0x01100000
• addon namespace entry: 011 DevOpsOfChaos
• default status: disabled

The new check in nofForester::GetPointQuality() is gated behind:

world->GetGGS().isEnabled(AddonId::FORESTER_FARM_FIELD_AVOIDANCE)

[stefson]

can you still use the forester to spam a big forest to block your enemy at bottlenecks?

[DevOpsOfChaos]

Yes, this PR intentionally does not change that.

Foresters can still plant normal forests as before, including in places that may be tactically annoying or blocking. This change is only about one narrow case: a forester should not choose a point that a completed own farm could currently use as a new grain field.

So this is not an anti-forest-spam or anti-bottleneck-blocking change. It does not add global land reservation, enemy-distance checks, chokepoint logic, or any broader restriction on forester planting.

The only newly rejected planting spots are spots that match the existing farmer field-placement rules for the same player.

[Spikeone]

I think this should be an addon since it does change the default behavior of the game. Part of the original feeling and gameplay is foresters blocking stuff you hate him doing.

[DevOpsOfChaos]

Fair point. I agree that this changes default gameplay behavior, even if the change is intentionally narrow.

I’ll put this on my TODO list and look into converting it into an addon instead of changing the default behavior directly.

[Flamefire]

@Flow86 Similar to the Fisher issue: I'd make GetPointQuality public in all descendants of nofFarmhand for consistency. This avoids "hacks" like this.

@DevOpsOfChaos This shouldn't be a pointer. And if the "cast/decay" is required it could be done in the parameter type of isPointAvailable instead to avoid an extra, potentially confusing variable.
But that depends on the resolution of the above.

[DevOpsOfChaos]

Done. I only cleaned up the test pointer.