Add single-soldier coin training addon#1928
Open
DevOpsOfChaos wants to merge 3 commits intoReturn-To-The-Roots:masterfrom
Open
Add single-soldier coin training addon#1928DevOpsOfChaos wants to merge 3 commits intoReturn-To-The-Roots:masterfrom
DevOpsOfChaos wants to merge 3 commits intoReturn-To-The-Roots:masterfrom
Conversation
0805fe3 to
b8c1f50
Compare
Flamefire
reviewed
May 2, 2026
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
659905e to
707fef9
Compare
Author
|
Pushed a small follow-up. This fixes the formatting issue and moves the addon ID into my own addon namespace as No gameplay behavior change. |
Flamefire
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SINGLE_SOLDIER_COIN_TRAININGaddonMotivation
By default, one consumed gold coin can promote a chain of eligible soldiers in a military building. This can make coin usage much more efficient when several promotable soldiers are present, but it also encourages micromanagement when players want to control coin efficiency more narrowly.
This addon provides an optional alternative where each delivered coin promotes only one eligible soldier. The selected soldier is the lowest-rank soldier that can still be promoted, matching the narrow behavior discussed in #1418.
The goal is not to replace the existing training model. It is a small optional gameplay variant for players who prefer one-coin-one-promotion behavior.
Scope / safety notes
This PR only changes how many soldiers one consumed coin can promote when the addon is enabled.
It intentionally does not change:
When the addon is disabled, the existing promotion-chain behavior remains unchanged.
Validation
Test_integrationlocally with Visual Studio 2022 / DebugTest_integration.exe --run_test=AttackSuite/CoinTrainingUpgradesRankChainByDefault --report_level=shortTest_integration.exe --run_test=AttackSuite/SingleSoldierCoinTrainingUpgradesOnlyLowestRankSoldier --report_level=shortTest_integration.exe --run_test=AttackSuite --report_level=short --log_level=errorFixes #1418