Ignore isolated fish resources for fisheries

[DevOpsOfChaos]

Summary

• remove fish resources from non-water and isolated one-node water during world resource setup
• keep connected/larger water with fish usable for fisheries
• keep fisher runtime checks simple by relying on normalized resource data
• add regression coverage for isolated fish water versus connected water

Motivation

Fisheries could still produce fish from an isolated one-node water pond if that node had a fish resource. In the original behavior described in #1171, such isolated water should be exhausted without producing fish.

This change keeps larger/connected water usable, but ignores fish resources on isolated water points.

Validation

• Built Test_integration locally with Visual Studio 2022 / Debug
• Ran Test_integration.exe --run_test=BuildingSuite/FisherIgnoresIsolatedFishWater --report_level=short
• Result: 1 test case passed, 6 assertions passed
• Ran Test_integration.exe --run_test=BuildingSuite --report_level=short

Fixes #1171

[DevOpsOfChaos]

Updated. I cleaned up the test as requested.

The extra nofFarmhand reference is now only kept where it is needed to call GetPointQuality, and the unnecessary unsigned casts are gone. I also fixed the small formatting/include-order cleanup before pushing.

Validation:

• Built Test_integration
• Ran BuildingSuite/FisherIgnoresIsolatedFishWater
• Ran BuildingSuite

[Flamefire]

Thinking about this again: Wouldn't it make more sense to "fix" the map during loading?
I.e. remove fish resources in <=1-water places. This would simplify the runtime check to "is there fish?" which then improves performance.
The terrain cannot change at runtime, can it? so we'd only need to do those checks once.

@Spikeone ?

[DevOpsOfChaos]

Thinking about this again: Wouldn't it make more sense to "fix" the map during loading? I.e. remove fish resources in <=1-water places. This would simplify the runtime check to "is there fish?" which then improves performance. The terrain cannot change at runtime, can it? so we'd only need to do those checks once.

@Spikeone ?

I reworked this in the direction you suggested.

The isolated/non-water fish cleanup now happens once in GameWorld::SetupResources(), so the fisher runtime path can stay simple and only check for fish resources again.

Connected water with fish is unchanged; isolated one-node water and non-water fish resources are normalized away during world resource setup.

Validation:

• built Test_integration
• ran BuildingSuite/FisherIgnoresIsolatedFishWater
• ran BuildingSuite
• git diff --check upstream/master...HEAD