fix(dev-console): register telnet connections + echo command output - #2
Open
JeanxPereira wants to merge 1 commit into
Open
fix(dev-console): register telnet connections + echo command output#2JeanxPereira wants to merge 1 commit into
JeanxPereira wants to merge 1 commit into
Conversation
Two fixes make the reactivated dev console actually usable end-to-end: - Poll TelnetTransport +0x1c/+0x20 each frame before draining commands. GetNextCommand (+0x14) only accumulates keystrokes for a client whose per-connection line-editor state is registered, and only PollNewConnection (+0x1c) allocates+registers it (and sends IAC WILL-ECHO). Without it a TCP client connected but every byte was discarded — no command ever executed. - Mirror AppConsole output back to the client. Detours FUN_00866230 (the registry's line broadcast) and forwards each line to the active connection via the transport's own Send (vtable +0xc), then calls through. The hook is installed on the main thread in StartOnce, NOT in DevConsoleInit — a Detours commit under the DllMain loader lock prevents the game from launching. Proven in-game: connect over telnet, `help` lists the registered cheats, `toggleCaptureUI`/`prop`/etc. run and their output returns over the socket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the reactivated Darkspore dev console actually usable end-to-end over telnet. Two fixes on top of the v1 opt-in module (
console_portin recap.cfg).1. Register telnet connections (input)
v1 connected at the TCP level but every keystroke was discarded — no command ever ran.
TelnetTransport::GetNextCommand(+0x14) only accumulates bytes for a client whose per-connection line-editor state (a0x100cblock) is registered, and onlyPollNewConnection(+0x1c) allocates+registers it (and sends the IAC WILL-ECHO). The retailProcessCommandpolls+0x1c/+0x20every frame before draining; v1 skipped it.Drain()now polls both each frame before the command loop.2. Echo command output back (output)
Command output went to the game's internal AppConsole sink, never to the socket. Detours
FUN_00866230(the registry's line broadcast,__thiscall(registry, line)) and mirrors each line to the active connection via the transport's ownSend(vtable+0xc), then calls through so in-game sinks still receive it. The connection is cached from the command object each drain.Critical: the Detours hook is installed on the game's main thread in
StartOnce, not inDevConsoleInit— aDetourTransactionCommitunder theDllMainloader lock prevents the game from launching.Verified in-game
Connect over telnet →
helplists the registered cheats →option/prop/toggleCaptureUI/quitrun and their output returns over the socket.Note:
app/statecommands are dead code in the retail ship build (their registrars are never invoked), so they remain unavailable by design — the reachable AppConsole cheat registry (option/prop/killallhints/movie/blocksmode/toggleCaptureUI/history/quit) is the live surface.