Replace isValid() calls with assert()
#1596
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
=========================================
Coverage 97.43% 97.43%
Complexity 981 981
=========================================
Files 211 211
Lines 2259 2259
=========================================
Hits 2201 2201
Misses 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
henriquemoody
force-pushed
the
docs/assert
branch
8 times, most recently
from
5d8119a to
d4d70ce
Compare
There's more value on showing how `assert()` displays the validation messages than simply showing if `isValid()` returns `true` or `false`. However, that increases the chances of having outdated documentation, so I created a console command that updates the Markdown files with the correct message.
henriquemoody
force-pushed
the
docs/assert
branch
from
d4d70ce to
98cd28f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's more value on showing how
assert()displays the validation messages than simply showing ifisValid()returnstrueorfalse.However, that increases the chances of having outdated documentation, so I created a console command that updates the Markdown files with the correct message.