Remove redundant checks already covered by is_callable()#13
Merged
henriquemoody merged 1 commit intomainfrom May 10, 2026
Merged
Remove redundant checks already covered by is_callable()#13henriquemoody merged 1 commit intomainfrom
henriquemoody merged 1 commit intomainfrom
Conversation
Before this change, the array callable branches included explicit isset(), is_string(), and is_object() checks to narrow the type for static analysis. After updating PHPStan, it now understands that is_callable() on an array already guarantees those conditions, making the extra checks dead code that adds noise without providing safety. Assisted-by: Claude Code (claude-sonnet-4-6)
henriquemoody
force-pushed
the
is_callable
branch
from
62c70f8 to
742bf04
Compare
henriquemoody
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…able()
Before this change, the array callable branches included explicit isset(), is_string(), and is_object() checks to narrow the type for static analysis. After updating PHPStan, it now understands that is_callable() on an array already guarantees those conditions, making the extra checks dead code that adds noise without providing safety.
Assisted-by: Claude Code (claude-sonnet-4-6)