-
Notifications
You must be signed in to change notification settings - Fork 4
RU-T39 Working on Changerawr build step #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR updates the React Native CI workflow to improve release notes handling. It replaces variable interpolation with Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/react-native-cicd.yml (1)
404-404: Consider removing the unusedRELEASE_NOTESvariable.Line 404 assigns the file content to
RELEASE_NOTES, but the Changerawr step usesjq --rawfileto read the file directly (line 410), so this variable is never referenced. You can safely remove this line for clarity.- # Read release notes and preserve markdown formatting - RELEASE_NOTES=$(<RELEASE_NOTES.md) VERSION="7.${{ github.run_number }}"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/react-native-cicd.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (2)
.github/workflows/react-native-cicd.yml (2)
305-307: Correct approach to strip auto-generated comment line.Adding the grep exclusion to filter out the HTML comment marker is the right way to clean up CodeRabbit-generated content from PR bodies. The pattern is specific and won't inadvertently remove other content.
407-418: Good use ofjq --rawfilefor multiline markdown handling.Using
--rawfile notes RELEASE_NOTES.mdinstead of variable interpolation is the correct approach to safely embed multiline Markdown content into JSON. This avoids escaping issues and malformed JSON when content includes special characters or newlines. The payload construction properly references$noteson line 418.
|
Approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is approved.
Summary by CodeRabbit