-
Notifications
You must be signed in to change notification settings - Fork 4
RU-T39 Trying to fix changerawr build. #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe GitHub Actions CI/CD workflow is updated to modify JSON payload construction for release fields. The changes include converting title expressions to parenthesized form, adjusting content field quoting, and adding explicit type-casting to string-typed tag fields using Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/react-native-cicd.yml (1)
421-421: Redundanttostringfilters on already-stringified variables.The variables passed via
--arg(platform, buildNumber, commitSha, buildUrl) are already strings in jq. Applying| tostringis defensive but redundant—--argguarantees string values, so these filters have no practical effect. They won't break anything, but they can be simplified to$platform,$buildNumber, etc. if you prefer clarity.If you'd like to simplify this, you can remove the
| tostringfilters:- "name": ($platform | tostring) + "name": $platformApply the same change to lines 425, 429, and 433.
Also applies to: 425-425, 429-429, 433-433
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/react-native-cicd.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/react-native-cicd.yml (1)
416-417: Critical bug fix: Content field now sends actual release notes instead of literal string.Line 417 is the key fix here. The original
"$notes"was a literal string in the jq filter, which would have sent the text$notesto the API instead of the actual release notes content. Changing to$notescorrectly sends the variable value. Line 416's parenthesized concatenation also properly formats the title string.
|
Approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is approved.
Summary by CodeRabbit
Release Notes