Skip to content

Pass view_as_user_id when fetching home feed #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicktytarenko merged 1 commit into from
May 29, 2026
+15 −1
Merged

Pass view_as_user_id when fetching home feed #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions components/Feed/Feed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ export const Feed: FC<FeedProps> = ({ defaultTab, initialFeedData }) => {
const orderingParam = searchParams.get('ordering');
const filterParam = searchParams.get('filter');
const userIdParam = searchParams.get('user_id');
const viewAsUserIdParam = searchParams.get('view_as_user_id');
const viewAsUserId =
viewAsUserIdParam && !Number.isNaN(Number(viewAsUserIdParam))
? Number(viewAsUserIdParam)
: undefined;
const [ordering, setOrdering] = useState<string | undefined>(
orderingParam || getDefaultOrdering(defaultTab)
);
Expand All @@ -62,6 +67,7 @@ export const Feed: FC<FeedProps> = ({ defaultTab, initialFeedData }) => {
ordering,
filter: filterParam || undefined,
userId: userIdParam || undefined,
viewAsUserId,
};

const {
Expand Down
6 changes: 5 additions & 1 deletion hooks/useFeed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ interface UseFeedOptions {
ordering?: string;
filter?: string;
userId?: string;
viewAsUserId?: number;
isDebugMode?: boolean;
initialData?: {
entries: FeedEntry[];
Expand Down Expand Up @@ -106,7 +107,8 @@ export const useFeed = (activeTab: FeedTab | FundingTab, options: UseFeedOptions
options.ordering !== currentOptions.ordering ||
options.isDebugMode !== currentOptions.isDebugMode ||
options.filter !== currentOptions.filter ||
options.userId !== currentOptions.userId;
options.userId !== currentOptions.userId ||
options.viewAsUserId !== currentOptions.viewAsUserId;

if (relevantOptionsChanged) {
setCurrentOptions(options);
Expand Down Expand Up @@ -148,6 +150,7 @@ export const useFeed = (activeTab: FeedTab | FundingTab, options: UseFeedOptions
includeHotScoreBreakdown: options.isDebugMode,
filter: options.filter,
userId: options.userId,
viewAsUserId: options.viewAsUserId,
});

setEntries(result.entries);
Expand Down Expand Up @@ -194,6 +197,7 @@ export const useFeed = (activeTab: FeedTab | FundingTab, options: UseFeedOptions
includeHotScoreBreakdown: options.isDebugMode,
filter: options.filter,
userId: options.userId,
viewAsUserId: options.viewAsUserId,
});
setEntries((prev) => [...prev, ...result.entries]);
setHasMore(result.hasMore);
Expand Down
4 changes: 4 additions & 0 deletions services/feed.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export class FeedService {
filter?: string;
status?: string;
userId?: string;
viewAsUserId?: number;
}): Promise<{ entries: FeedEntry[]; hasMore: boolean }> {
const queryParams = new URLSearchParams();
if (params?.page) queryParams.append('page', params.page.toString());
Expand All @@ -47,6 +48,9 @@ export class FeedService {
if (params?.filter) queryParams.append('filter', params.filter);
if (params?.status) queryParams.append('status', params.status);
if (params?.userId) queryParams.append('user_id', params.userId);
if (params?.viewAsUserId) {
queryParams.append('view_as_user_id', params.viewAsUserId.toString());
}

// Determine which endpoint to use
const basePath =
Expand Down