Fixes for icx 2025; Cleanup

[johguenther]

No description provided.

[johguenther]

wait on Embree release

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

@johguenther I've opened a new pull request, #33, to work on those changes. Once the pull request is ready, I'll request review from you.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 48 out of 61 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

cmake/openvkl_ispc.cmake:16

• The failure message still says ISPC is expected in PATH or in a sibling directory (and references "OSPRay"), but the search logic now only uses find_program(... ispc ...) without sibling-directory hints. Please update the message to match the actual search behavior (and project name) so users aren't misled when configuring.
  openvkl/include/openvkl/ispc_cpp_interop.h:86
• floatbits()/intbits() C/C++ fallback helpers were removed from this public interop header, but they are still referenced from C++-compiled code paths (e.g., GPU compute headers call intbits()/floatbits()). Unless another included header now provides these symbols, this change will cause C++ compilation errors. Consider restoring these helpers here (e.g., via std::bit_cast/memcpy-based implementations) or updating all call sites to a guaranteed-available replacement.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 47 out of 60 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

openvkl/include/openvkl/ispc_cpp_interop.h:86

• The removal of the C++ implementations of floatbits()/intbits() breaks C++ compilation for code that still relies on these helpers (e.g., openvkl/devices/gpu/compute/amr/KDTree.h uses floatbits(), and openvkl/devices/gpu/compute/vklIterators.h uses intbits()). Please either restore these helpers here (preferably implemented via std::memcpy/std::bit_cast to avoid aliasing issues) or update all C++ call sites to use a replacement helper that is available in C++ builds.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.