Skip to content

Fix SDK version header name and value format#25

Merged
jdwyah merged 3 commits intomainfrom
fix/sdk-version-header
Feb 25, 2026
Merged

Fix SDK version header name and value format#25
jdwyah merged 3 commits intomainfrom
fix/sdk-version-header

Conversation

@jdwyah
Copy link
Contributor

@jdwyah jdwyah commented Feb 25, 2026

Summary

  • Fixed header name from X-Reforge-Client-Version to X-Reforge-SDK-Version (using the existing VersionHeader constant)
  • Fixed value format from reforge-python-{version} to sdk-python-{version}
  • Python was the only SDK with this bug — all others (Go, Node, Java, Ruby, JavaScript, React) already use the correct header and format

Test plan

  • Verify SDK sends X-Reforge-SDK-Version: sdk-python-{version} header on API requests
  • Confirm server correctly parses the version header (matches REFORGE_HEADER_PATTERN)

🤖 Generated with Claude Code

jdwyah and others added 2 commits February 25, 2026 15:20
The Python SDK was sending the wrong header name (`X-Reforge-Client-Version`)
and wrong value format (`reforge-python-{version}`). The server expects
`X-Reforge-SDK-Version` with format `sdk-python-{version}`, matching all
other SDKs (Go, Node, Java, Ruby, JavaScript, React).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link

@ayip8 ayip8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jdwyah jdwyah merged commit 15cebec into main Feb 25, 2026
7 checks passed
@jdwyah jdwyah deleted the fix/sdk-version-header branch February 25, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants