revert: remove open-world evidence foundation - #413
Merged
Conversation
Use an explicit unset sentinel for the last anomaly time so hosts with less than one hour of monotonic uptime do not suppress the first threshold crossing.
📝 WalkthroughWalkthroughThe change simplifies session outcomes, removes finalization receipts and purge execution claims, updates learning billing to use durable IDs or counts, removes selected retention and search-exposure infrastructure, and revises related storage, documentation, and tests. ChangesSession outcome simplification
Learning finalization and billing
Governance purge simplification
Retention and runtime cleanup
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 9
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
reflexio/server/services/storage/sqlite_storage/_base.py (2)
2468-2480: 🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy liftAdd a guarded rebuild migration for
session_outcomes.
CREATE TABLE IF NOT EXISTSleaves the#407table unchanged. ItsNOT NULLcolumns includeoutcome_id,outcome_revision,outcome_contract_digest, andfinalized_trajectory_digest. The current insert omits these columns and fails withNOT NULL constraint failed: session_outcomes.outcome_id. Add the migration tomigrate(), preserve compatible rows, handle existing'unknown'rows, and recreate the indexes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@reflexio/server/services/storage/sqlite_storage/_base.py` around lines 2468 - 2480, The session_outcomes schema needs a guarded rebuild migration because the existing `#407` table has additional NOT NULL columns that the current inserts omit. Add migration logic in migrate() to detect the incompatible schema, create the corrected table including outcome_id, outcome_revision, outcome_contract_digest, and finalized_trajectory_digest, preserve compatible rows while mapping existing 'unknown' outcomes appropriately, swap the tables safely, and recreate all session_outcomes indexes.
666-667: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winKeep the SQLite 3.35.0 guard or provide compatible fallbacks.
DROP COLUMNandRETURNINGboth require SQLite 3.35.0 or newer. Older SQLite runtimes can fail during migration or later storage operations.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@reflexio/server/services/storage/sqlite_storage/_base.py` around lines 666 - 667, Preserve the SQLite 3.35.0 version guard in the storage initialization and migration flow around the database path setup. For older runtimes, provide compatible fallbacks for every DROP COLUMN and RETURNING operation, ensuring migrations and subsequent storage operations continue without relying on unsupported SQLite syntax.reflexio/server/services/extraction/resume_worker.py (1)
887-905: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy liftBilling counts pre-persist items, not persisted rows.
itemsis the list handed to_finalize_extracted_items. That method runs_resolve_write_plan, which consolidates and can drop candidates before persist._record_finalized_learningsthen metersitems, so dropped candidates are still billed:
- Playbook: a dropped item keeps
user_playbook_id=0, the code falls back tocount=len(items), and the dropped item is counted.- Profile:
profile_idis assigned by the extractor before persist, so a consolidated-away profile still produces an entity-backed event for a row that was never written.Meter the persisted rows instead.
_finalize_extracted_itemsalready builds the write plan, so return or expose the persisted survivors and pass those to_record_finalized_learnings.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@reflexio/server/services/extraction/resume_worker.py` around lines 887 - 905, Update _finalize_extracted_items and both profile/playbook callers in the resume worker so finalization returns or otherwise exposes the persisted survivor rows produced by _resolve_write_plan. Pass only those survivors to _record_finalized_learnings, preserving the existing entity_type values, rather than passing the original items list.reflexio/server/services/storage/sqlite_storage/governance/_erase_execution.py (1)
375-384: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winUse
BEGIN IMMEDIATEfor the validate-then-delete transaction.With WAL enabled, a competing writer can commit after validation. The deferred transaction then fails with
SQLITE_BUSYwhen its snapshot is upgraded for deletion. UseBEGIN IMMEDIATEto acquire the write lock before validation.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@reflexio/server/services/storage/sqlite_storage/governance/_erase_execution.py` around lines 375 - 384, Update the transaction start in the validate-then-delete flow containing _validate_prepared_delete_target_matrix_locked and _validate_hide_for_rebuild_targets_locked to use BEGIN IMMEDIATE instead of BEGIN, acquiring the write lock before validation while leaving the subsequent validation and deletion steps unchanged.
🧹 Nitpick comments (1)
reflexio/server/services/storage/sqlite_storage/governance/_erase_execution.py (1)
271-276: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winReturn a stable key set from
_clear_user_data_for_governance_locked.The
session_outcomeskey now appears only whenrowcountis truthy. Every other key is always present. The method declaresdict[str, int], andapply_governance_user_data_deletereturns this dict to callers. A caller that indexescounts["session_outcomes"]raisesKeyErrorfor the common zero-deletion case, whileclear_session_outcomes_for_userinreflexio/server/services/storage/sqlite_storage/_session_outcomes.pyalways returns that key.
apply_governance_user_data_deletealready reads the value withcounts.get(key, 0)on line 392, so always emitting the key changes nothing in the delete-target matrix. It does require updating the exact-equality assertion intests/server/services/storage/sqlite_storage/test_governance_storage.pyaround line 3273.♻️ Proposed refactor
return { - **( - {"session_outcomes": session_outcomes_cur.rowcount} - if session_outcomes_cur.rowcount - else {} - ), + "session_outcomes": session_outcomes_cur.rowcount, "interactions": interactions_cur.rowcount,🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@reflexio/server/services/storage/sqlite_storage/governance/_erase_execution.py` around lines 271 - 276, Update _clear_user_data_for_governance_locked to always include the session_outcomes key, using session_outcomes_cur.rowcount even when it is zero, while preserving the existing values for all other keys. Update the exact expected dictionary assertion in test_governance_storage.py to include session_outcomes: 0 for the zero-deletion case.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@reflexio/models/api_schema/domain/entities.py`:
- Around line 957-958: Update the comment describing the clear-user-data scope
near the relevant clear-user-data declaration to explicitly include session
outcomes alongside interactions, requests, playbooks, and profiles; do not
change the deletion behavior.
In `@reflexio/server/billing_meter.py`:
- Around line 93-97: The count fallback in the finalized-learning recording flow
must reuse a stable idempotency key across retries instead of generating a new
UUID per call. Update the fallback around _record_finalized_learnings and its
billing-meter helper to derive the event key from the finalized run and batch,
or persist and reuse an idempotency marker before emitting the aggregate event;
retain the existing no-op behavior for count <= 0.
In `@reflexio/server/services/extraction/resume_worker.py`:
- Around line 318-321: Update record_learnings_generated in the finalization
flow to use a deterministic batch event key derived from run.id instead of
generating a new UUID on each attempt. Ensure _retry_finalization reuses the
same key as the initial finalization so fallback learnings are not
double-counted.
In `@reflexio/server/services/playbook/components/aggregator.py`:
- Around line 1964-1974: Update _run_incremental to call
_record_learnings_generated before its return, using the saved playbooks’
durable agent_playbook_id values and the same total-count fallback behavior as
the existing aggregation path; add a regression test covering both durable IDs
and the fallback count.
In `@reflexio/server/services/playbook/service.py`:
- Around line 604-607: Update emit_generation_side_effects and
_finalize_extracted_items to contain exceptions from both
_enqueue_user_playbook_optimization and _trigger_playbook_aggregation locally
after persistence completes. Log each scheduler failure without re-raising it,
so post-commit finalization remains successful and retries cannot repeat durable
writes or billing.
In `@reflexio/server/services/storage/sqlite_storage/_governance.py`:
- Around line 407-411: Update the governance schema migration, including
_ensure_governance_subject_ref_columns, to cover session_outcomes: backfill
nullable or missing governance_subject_ref values for legacy rows using the
appropriate subject mapping, then enforce the existing NOT NULL constraint.
Ensure purge-completion logic cannot be bypassed by legacy session_outcomes
rows.
In `@reflexio/server/services/storage/sqlite_storage/_session_outcomes.py`:
- Around line 204-213: Update clear_session_outcomes_for_user to delete
session_outcomes by user_id as well as governance_subject_ref, so erasure still
removes rows created before secret rotation. Preserve the existing locking,
commit, and rowcount behavior while ensuring both current and previously derived
identifiers are covered.
In `@reflexio/server/services/storage/sqlite_storage/governance/_purge.py`:
- Around line 346-377: Update fail_purge_operation to roll back the connection
before either ValueError raised after a zero-row UPDATE, matching the try/except
rollback handling in fail_subject_erasure_barrier. Ensure the rollback occurs
before checking the existing operation status or raising the not-found error,
while preserving the existing successful commit and return behavior.
In `@reflexio/server/services/storage/storage_base/__init__.py`:
- Around line 150-151: Update the clear_user_data docstring to include session
outcomes among the deleted user data and explicitly state that session-outcome
deletions are intentionally omitted from the returned dictionary, while
preserving the existing description of agent_playbooks.
---
Outside diff comments:
In `@reflexio/server/services/extraction/resume_worker.py`:
- Around line 887-905: Update _finalize_extracted_items and both
profile/playbook callers in the resume worker so finalization returns or
otherwise exposes the persisted survivor rows produced by _resolve_write_plan.
Pass only those survivors to _record_finalized_learnings, preserving the
existing entity_type values, rather than passing the original items list.
In `@reflexio/server/services/storage/sqlite_storage/_base.py`:
- Around line 2468-2480: The session_outcomes schema needs a guarded rebuild
migration because the existing `#407` table has additional NOT NULL columns that
the current inserts omit. Add migration logic in migrate() to detect the
incompatible schema, create the corrected table including outcome_id,
outcome_revision, outcome_contract_digest, and finalized_trajectory_digest,
preserve compatible rows while mapping existing 'unknown' outcomes
appropriately, swap the tables safely, and recreate all session_outcomes
indexes.
- Around line 666-667: Preserve the SQLite 3.35.0 version guard in the storage
initialization and migration flow around the database path setup. For older
runtimes, provide compatible fallbacks for every DROP COLUMN and RETURNING
operation, ensuring migrations and subsequent storage operations continue
without relying on unsupported SQLite syntax.
In
`@reflexio/server/services/storage/sqlite_storage/governance/_erase_execution.py`:
- Around line 375-384: Update the transaction start in the validate-then-delete
flow containing _validate_prepared_delete_target_matrix_locked and
_validate_hide_for_rebuild_targets_locked to use BEGIN IMMEDIATE instead of
BEGIN, acquiring the write lock before validation while leaving the subsequent
validation and deletion steps unchanged.
---
Nitpick comments:
In
`@reflexio/server/services/storage/sqlite_storage/governance/_erase_execution.py`:
- Around line 271-276: Update _clear_user_data_for_governance_locked to always
include the session_outcomes key, using session_outcomes_cur.rowcount even when
it is zero, while preserving the existing values for all other keys. Update the
exact expected dictionary assertion in test_governance_storage.py to include
session_outcomes: 0 for the zero-deletion case.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 73256250-5714-46ee-a81f-6b7abcb8513d
📒 Files selected for processing (58)
README.mddocs/lib/methods/requests-sessions.tsreflexio/client/client.pyreflexio/lib/_session_outcome.pyreflexio/models/api_schema/domain/entities.pyreflexio/models/api_schema/domain/enums.pyreflexio/server/billing_meter.pyreflexio/server/callback_executor.pyreflexio/server/routes/search.pyreflexio/server/services/base_generation/_usage_billing.pyreflexio/server/services/base_generation_service.pyreflexio/server/services/deferred_learning_plan.pyreflexio/server/services/extraction/README.mdreflexio/server/services/extraction/resume_worker.pyreflexio/server/services/governance/service.pyreflexio/server/services/playbook/components/aggregator.pyreflexio/server/services/playbook/service.pyreflexio/server/services/profile/service.pyreflexio/server/services/search_exposure.pyreflexio/server/services/storage/governance_claims.pyreflexio/server/services/storage/governance_validation.pyreflexio/server/services/storage/retention.pyreflexio/server/services/storage/retention_mixin.pyreflexio/server/services/storage/session_outcome_identity.pyreflexio/server/services/storage/sqlite_storage/_base.pyreflexio/server/services/storage/sqlite_storage/_governance.pyreflexio/server/services/storage/sqlite_storage/_session_outcomes.pyreflexio/server/services/storage/sqlite_storage/agent_run/_agent_run_store.pyreflexio/server/services/storage/sqlite_storage/base/_deletion.pyreflexio/server/services/storage/sqlite_storage/governance/_erase_execution.pyreflexio/server/services/storage/sqlite_storage/governance/_purge.pyreflexio/server/services/storage/sqlite_storage/governance/_subject_barrier.pyreflexio/server/services/storage/storage_base/__init__.pyreflexio/server/services/storage/storage_base/_session_outcomes.pyreflexio/server/services/storage/storage_base/agent_run/_agent_run_store.pyreflexio/server/services/storage/storage_base/governance/_erase_execution.pyreflexio/server/services/storage/storage_base/governance/_purge.pyreflexio/server/services/storage/storage_base/governance/_subject_barrier.pytests/client/test_session_outcomes_client.pytests/models/test_session_outcome_identity.pytests/server/api_endpoints/test_session_outcomes_integration.pytests/server/routes/test_search_exposure_boundary.pytests/server/services/extraction/test_resume_worker.pytests/server/services/governance/test_governance_local_e2e.pytests/server/services/governance/test_subject_write_barrier_sqlite.pytests/server/services/storage/sqlite_storage/test_agent_run_storage.pytests/server/services/storage/sqlite_storage/test_governance_retrieved_learning.pytests/server/services/storage/sqlite_storage/test_governance_storage.pytests/server/services/storage/sqlite_storage/test_session_id_migration.pytests/server/services/storage/sqlite_storage/test_session_outcome_migration.pytests/server/services/storage/test_sqlite_storage.pytests/server/services/storage/test_storage_contract_clear_user_data.pytests/server/services/storage/test_storage_contract_retention.pytests/server/services/storage/test_storage_contract_session_outcomes.pytests/server/services/test_generation_billing_emission.pytests/server/services/test_non_extraction_learning_metering.pytests/server/services/test_search_exposure.pytests/server/test_billing_meter_events.py
💤 Files with no reviewable changes (21)
- README.md
- tests/models/test_session_outcome_identity.py
- tests/client/test_session_outcomes_client.py
- reflexio/models/api_schema/domain/enums.py
- reflexio/server/services/storage/session_outcome_identity.py
- reflexio/server/services/storage/governance_validation.py
- reflexio/server/services/storage/sqlite_storage/agent_run/_agent_run_store.py
- reflexio/server/services/storage/storage_base/_session_outcomes.py
- reflexio/server/services/storage/governance_claims.py
- tests/server/services/storage/sqlite_storage/test_agent_run_storage.py
- reflexio/server/services/search_exposure.py
- tests/server/services/storage/test_storage_contract_retention.py
- reflexio/server/routes/search.py
- reflexio/server/services/storage/storage_base/agent_run/_agent_run_store.py
- tests/server/services/storage/test_storage_contract_session_outcomes.py
- tests/server/routes/test_search_exposure_boundary.py
- tests/server/services/test_search_exposure.py
- reflexio/server/services/storage/retention.py
- tests/server/services/storage/test_sqlite_storage.py
- tests/server/services/storage/test_storage_contract_clear_user_data.py
- tests/server/services/storage/sqlite_storage/test_session_outcome_migration.py
Preserve session-outcome compatibility across the #407 downgrade, make governance erasure and transactions robust, and keep learning metering retry-safe and aligned with persisted survivors.
Contributor
Author
|
CodeRabbit review-body findings are addressed in
Validation after the fixes: affected files |
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
reflexio/server/services/storage/sqlite_storage/governance/_purge.py (2)
260-271: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winRoll back failed
record_purge_targetwrites.If either DML statement or
commit()raises, callself.conn.rollback()before re-raising. Otherwise, the implicit transaction can remain active and hold SQLite write locks. Add a failure-path test that assertsstorage.conn.in_transaction is False.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@reflexio/server/services/storage/sqlite_storage/governance/_purge.py` around lines 260 - 271, The purge-target persistence flow around _record_purge_target_locked must roll back the SQLite transaction whenever the DML operation or conn.commit() raises, then re-raise the original exception. Add a failure-path test for this flow that verifies storage.conn.in_transaction is False after the error.
191-230: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winAcquire the SQLite write lock before each state check.
When two
SQLiteStorageBaseinstances share a database,self._lockdoes not serialize them. Inbegin_purge_operation, the unique index prevents duplicate rows, but one concurrent caller can fail instead of receiving the existing idempotent operation. Inprepare_governance_erase_targets, the later caller can overwrite advanced targets withpendinganddeleted_count=0.Start
BEGIN IMMEDIATEbefore each state check, re-check inside the transaction, and roll back before early returns. Add two-connection regression tests for both paths.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@reflexio/server/services/storage/sqlite_storage/governance/_purge.py` around lines 191 - 230, Update begin_purge_operation and prepare_governance_erase_targets to start a BEGIN IMMEDIATE transaction before reading existing state, so separate SQLiteStorageBase instances serialize writes and re-check state inside the transaction. Roll back before returning an existing idempotent operation or otherwise exiting early, and preserve advanced erase targets instead of resetting them. Add two-connection regression tests covering both concurrent paths.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@reflexio/server/services/playbook/service.py`:
- Around line 655-657: The synchronous finalization flows need one outer
transaction so creation and lineage updates commit atomically. In
reflexio/server/services/playbook/service.py lines 655-657, wrap
_persist_write_plan and _dispatch_playbook_schedulers in a single commit_scope
covering creation and consolidation lineage; in
reflexio/server/services/profile/service.py lines 354-355, apply the same
transaction boundary around creation and supersession. Preserve the existing
return behavior and avoid relying on the individual storage-method commits.
In `@reflexio/server/services/storage/sqlite_storage/_base.py`:
- Around line 845-859: The schema fast path in the guard around
governance_column incorrectly accepts an empty-string default for
governance_subject_ref. Reject this legacy schema when its column definition has
DEFAULT '' (or validate that existing values are nonblank) so it proceeds
through the rebuild path, and add a regression case covering the exact TEXT NOT
NULL DEFAULT '' definition.
In
`@tests/server/services/storage/test_playbook_aggregation_state_integration.py`:
- Around line 1038-1049: Update the test’s PlaybookAggregatorRequest invocation
to pass the deterministic operation_key "test-run-1", then change the
learning_meter assertion to expect request_id="test-run-1" directly instead of
reading it from learning_meter.call_args. Keep the remaining assertions
unchanged.
---
Outside diff comments:
In `@reflexio/server/services/storage/sqlite_storage/governance/_purge.py`:
- Around line 260-271: The purge-target persistence flow around
_record_purge_target_locked must roll back the SQLite transaction whenever the
DML operation or conn.commit() raises, then re-raise the original exception. Add
a failure-path test for this flow that verifies storage.conn.in_transaction is
False after the error.
- Around line 191-230: Update begin_purge_operation and
prepare_governance_erase_targets to start a BEGIN IMMEDIATE transaction before
reading existing state, so separate SQLiteStorageBase instances serialize writes
and re-check state inside the transaction. Roll back before returning an
existing idempotent operation or otherwise exiting early, and preserve advanced
erase targets instead of resetting them. Add two-connection regression tests
covering both concurrent paths.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1307db0e-796f-4f09-ba00-aeea151e8f6b
📒 Files selected for processing (23)
reflexio/models/api_schema/domain/entities.pyreflexio/server/billing_meter.pyreflexio/server/routes/system.pyreflexio/server/services/base_generation_service.pyreflexio/server/services/extraction/resume_worker.pyreflexio/server/services/playbook/components/aggregator.pyreflexio/server/services/playbook/service.pyreflexio/server/services/profile/service.pyreflexio/server/services/storage/sqlite_storage/_base.pyreflexio/server/services/storage/sqlite_storage/_governance.pyreflexio/server/services/storage/sqlite_storage/_session_outcomes.pyreflexio/server/services/storage/sqlite_storage/governance/_erase_execution.pyreflexio/server/services/storage/sqlite_storage/governance/_purge.pyreflexio/server/services/storage/storage_base/__init__.pytests/server/services/extraction/test_resume_worker.pytests/server/services/playbook/test_playbook_generation_service.pytests/server/services/storage/sqlite_storage/test_governance_storage.pytests/server/services/storage/sqlite_storage/test_session_outcome_downgrade_migration.pytests/server/services/storage/test_playbook_aggregation_state_integration.pytests/server/services/storage/test_storage_contract_clear_user_data.pytests/server/services/storage/test_storage_contract_session_outcomes.pytests/server/services/test_non_extraction_learning_metering.pytests/server/test_billing_meter_events.py
🚧 Files skipped from review as they are similar to previous changes (10)
- reflexio/models/api_schema/domain/entities.py
- reflexio/server/services/base_generation_service.py
- tests/server/services/test_non_extraction_learning_metering.py
- tests/server/services/storage/test_storage_contract_session_outcomes.py
- reflexio/server/services/extraction/resume_worker.py
- reflexio/server/services/storage/sqlite_storage/_governance.py
- tests/server/services/storage/sqlite_storage/test_governance_storage.py
- reflexio/server/services/playbook/components/aggregator.py
- reflexio/server/services/storage/sqlite_storage/_session_outcomes.py
- reflexio/server/services/storage/sqlite_storage/governance/_erase_execution.py
Make synchronous persistence atomic, serialize purge state transitions across SQLite connections, repair legacy outcome schemas with empty governance defaults, and strengthen metering coverage.
Contributor
Author
|
Addressed both outside-diff CodeRabbit findings in eebc0e5:
Validation: 301 affected-file tests passed; full non-E2E suite 5,535 passed, 73 skipped, 6 subtests; E2E 47 passed, 51 skipped; repo-wide Ruff clean; changed-file Pyright 0 errors and 0 warnings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Evidence foundation rollback
Dependent follow-ups
Review follow-ups
session_outcomestables into the restored schema, preservingsuccess/failurerows, backfilling governance subject references, and explicitly dropping unrepresentableunknownoutcomes with a warning.RETURNINGandDROP COLUMNusage.session_outcomesdeletion count.Validation follow-up
Test Plan
uv run ruff check reflexio testsuv run ruff format --check reflexio testsnpm --prefix docs run lint: 0 errors (3 existing warnings)cd docs && npx tsc --noEmitpython -c "import reflexio"Reverts
85a4b2255a96ef2a5b50f4cbe7c10758439e76b3, plus dependent follow-ups785a9e053ff771f40704bb7b0b5bbbe36048806aandeb88f44fd3b53457b76e8500ac1a30ba7d4ab16e.Summary by CodeRabbit
Changes
Documentation