In CMake, install BLAS::BLAS and LAPACK::LAPACK#840
Open
weslleyspereira wants to merge 2 commits intoReference-LAPACK:masterfrom
Open
In CMake, install BLAS::BLAS and LAPACK::LAPACK#840weslleyspereira wants to merge 2 commits intoReference-LAPACK:masterfrom
weslleyspereira wants to merge 2 commits intoReference-LAPACK:masterfrom
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #840 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1908 1908
Lines 186962 186962
=======================================
Misses 186962 186962 ☔ View full report in Codecov by Sentry. |
weslleyspereira
force-pushed
the
try-lapack_namespace
branch
from
9bc18bc to
c819999
Compare
langou
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to close #483.
Currently, FindLAPACK in CMake offers two ways to link LAPACK libraries:
LAPACK_LIBRARIES, an "uncached list of libraries (using full path name) to link against to use LAPACK".LAPACK::LAPACK, which is a CMake target.In current version of LAPACK, we install a target
${LAPACKLIB}, where LAPACKLIB is a variable that has to do with the name of the library installed in the system.This PR changes the installation to
LAPACK::LAPACKwhich agrees with FindLAPACK from CMake. The variableLAPACK_LIBRARIESremains unchanged. I also installBLAS::BLASinstead of the target${BLASLIB}to conform with FindBLAS from CMake.Notice that the only thing this PR does is to rename of two CMake variables (3, if we consider LAPACK::TMGLIB).
Comments are welcome!