Open
Conversation
grilledham
approved these changes
Feb 7, 2026
Collaborator
grilledham
left a comment
There was a problem hiding this comment.
Looks good.
Regarding allowed_entities.register(), it probably should have a check to prevent registering twice if we are going to move the event adding code inside register. The merge_dictionary code implies to me that it's setup such that multiple calls to register would be allowed, but I wonder if that is a good idea or if any maps actually make use of that. Either way as I don't think register gets called more than once per map, we don't have to solve this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
true)register)I'm evaluating if
do/modules/allowed_entitiesshould have some form of alert when calling.register()in order to not register the events twice by mistake. Although, that would be true even for each other module that has something like this as well (I believe?), so I'm not sure if needs to be added to be exxxxtra sure.I know some of the old modules have those type of checks for runtime stage...