feat: Add blackfroest scenario

[Bienenstock]

I hope there are no bugs left, I created this scenario a long time ago.
Have Fun!

[grilledham]

Cool, thanks for making the PR.

I had a quick look and this mostly seems fine.

One thing I did notice is if I start the map with _DEBUG = true I get this error.

[grilledham]

These 3 are missing from the German translation. Any reason for that?

[Bienenstock]

ups, idk, I created it a long time ago. i don't think they are used. I will check tomorrow

[Bienenstock]

fixed

[Bienenstock]

Cool, thanks for making the PR.

I had a quick look and this mostly seems fine.

One thing I did notice is if I start the map with _DEBUG = true I get this error.

I have a look tomorrow

[Bienenstock]

Cool, thanks for making the PR.

I had a quick look and this mostly seems fine.

One thing I did notice is if I start the map with _DEBUG = true I get this error.

fixed

[grilledham]

There are some warnings in the luacheck. The "cyclomatic complexity of function on_tick is too high" might be hard to fix but the others are probably worth looking at. I can bypass the checks if we think it's not worth the effort but probably worth a look first.

[grilledham]

I ran into an issue with trying to raise the on_entity_died event. Diggy uses defines.events.script_raised_destroy here instead.

[jacobwatkinsgit]

I have a bunch of patches but I can't commit them because git wants write permissions to someone elses repository.

@Bienenstock Here, before I throw my computer out the window:

Summary:
add destroy_tree to create_particles to make leaf-particles, the way destroy_rock creates stone-particles, fix function description (create_particle, not create_entity)

refactor black_forest_grow: iterates every tree on the map, doesn't error on invalid entities any more, checks every tree and reduces redundant tree checks

general code quality cleaning, like using entity.destroy{raise_destroy = true}, instead of manual script raised destroy + an empty destroy().

changed_files.zip