fix: pass workflow inputs to success and failure actions by harshit078 · Pull Request #2796 · Redocly/redocly-cli

harshit078 · 2026-05-04T10:55:54Z

What/Why/How?

Added the spec-parameters-in-by-context Arazzo rule
Added parameters property in interface of workflow for success and failure action objects.

Reference

#2735

Testing

Screenshots (optional)

Check yourself

This PR follows the contributing guide
All new/updated code is covered by tests
Core code changed? - Tested with other Redocly products (internal contributions only)
New package installed? - Tested in different environments (browser/node)
Documentation update has been considered

Security

The security impact of the change has been considered
Code follows company security practices and guidelines

Note

Medium Risk
Stricter default/spec rulesets can newly fail Arazzo lint on existing descriptions, and Respect workflow goto behavior changes when actions pass parameters.

Overview
Adds Arazzo spec-parameters-in-by-context so parameter in is required for workflow/step operation parameters and forbidden when the parent uses workflowId; success/failure actions may only define parameters when they reference a workflowId. The model gains ActionParameter / ActionParameters on onSuccess / onFailure, parameters-unique covers those lists, and Respect run-step merges action parameters into the target workflow’s inputs (same helper as step → child workflow). Docs, changeset, and preset wiring (error in spec / all / recommended-strict, warn in recommended) mean stricter Arazzo lint may surface new issues on existing files.

^{Reviewed by Cursor Bugbot for commit 41b8546. Bugbot is set up for automated code reviews on this repo. Configure here.}

changeset-bot · 2026-05-04T10:55:59Z

🦋 Changeset detected

Latest commit: a58b507

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@redocly/openapi-core	Minor
@redocly/respect-core	Minor
@redocly/cli	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

AlbinaBlazhko17 · 2026-05-12T08:47:55Z

Thanks @harshit078 for contribution! Please, fix the issue reported by bugbot. I left comment as well. Additionally, please add docs for a new rule.

harshit078 · 2026-05-18T10:04:31Z

Hey @AlbinaBlazhko17 , I have pushed a fix addressing both cursor and your comment along with addition of docs for spec-parameters-in-by-context hence made changes in v2 docs.

AlbinaBlazhko17 · 2026-05-20T06:55:38Z

+
+export const SpecParametersInByContext: Arazzo1Rule = () => {
+  return {
+    Step: {


Please, add to this rule Workflowvisitor, because you miss, that Workflow also accepts parameters per arazzo.ts:179.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 8b47027. Configure here.}

…tter handlingg

harshit078 · 2026-05-28T13:06:26Z

Hey @AlbinaBlazhko17 , I have addressed the comments you left and created a seperate parameter interface and used that. I am not sure on how to resolve the 2 failing test though. Thanks !

AlbinaBlazhko17 · 2026-05-29T14:13:21Z

  type: 'array',
  items: parameter,
 } as const;
+export const actionParameter = {


Add please spacing between Parameters, actionParameter and actionParameters.

AlbinaBlazhko17 · 2026-05-29T14:21:56Z

Hi @harshit078! Almost done, left minor comments, otherwise looks good.
Let me help you with the issues in CI:

To fix error in build and unit run npm run unit -- -u. This command will regenerate the snapshot, because you've added new types.
To fix error in code-style-check run npm run format. We use as a formatter Oxfmt, so please, make sure, that you installed in your IDE Oxc extension and use this formatter for our CLI repository.

harshit078 · 2026-05-29T16:06:19Z

Hi @AlbinaBlazhko17 , I have tried doing both the commands and pushed the commit for it but the tests still fails. Is there something I might be doing wrong ?

AlbinaBlazhko17 · 2026-06-02T16:31:30Z

Hi @harshit078! You fixed first batch of errors. Let's fix the second:

To fix build-and-unit run command npm run e2e -- -u to update two snapshots.
The code-style-check failed due to an error (listed below), you need to use isPlainObject.

  × oxlint-redocly-plugin(no-typeof-object): Avoid `typeof ... 'object'` comparison. Use `isPlainObject` helper instead.
   ╭─[packages/core/src/rules/arazzo/spec-parameters-in-by-context.ts:6:32]
 5 │ function isInlineParameter(parameter: Parameter): boolean {
 6 │   return Boolean(parameter) && typeof parameter === 'object' && !('reference' in parameter);
   ·                                ─────────────────────────────
 7 │ }
   ╰────

harshit078 · 2026-06-02T17:50:39Z

Hey @AlbinaBlazhko17 , thank you for helping me out. The PR is good to go on the check side.

DmitryAnansky · 2026-06-03T13:11:28Z

+'@redocly/cli': minor
+---
+
+Added the `spec-parameters-in-by-context` Arazzo rule, which validates that a parameter's `in` field is specified when the parent workflow, step, success action, or failure action does not reference a `workflowId`. Extended success and failure action objects to accept a `parameters` property that maps to workflow inputs.


Please make two separate changelog files:

one with the: "Extended success and failure action objects to accept a parameters property that maps to workflow inputs."

other with the rule updates: "Added the spec-parameters-in-by-context Arazzo rule, which validates that a parameter's in field is specified when the parent workflow, step, success action, or failure action does not reference a workflowId. "

DmitryAnansky · 2026-06-03T13:50:24Z

+
+## Design principles
+
+The Arazzo specification states that when a step, success action, or failure action specifies a `workflowId`, all parameters map to the referenced workflow's inputs and the `in` field MUST NOT be specified.


@harshit078
Please correct me if I’m wrong, but this statement seems to be inaccurate.
The Arazzo specification only mentions this for Success Action Object and Failure Action Object but not for the step.

A list of parameters that MUST be passed to a workflow as referenced by workflowId. If a Reusable Object is provided, it MUST link to a parameter defined in the [components/parameters](https://spec.openapis.org/arazzo/latest.html#components-object) of the current Arazzo document. The list MUST NOT include duplicate parameters. The `in` field MUST NOT be used.

https://spec.openapis.org/arazzo/latest.html#success-action-object

https://spec.openapis.org/arazzo/latest.html#failure-action-object

I’d also like to clarify whether step-level parameters that don’t include an in field should be merged into the success and failure action objects.
Here is my question for the community => https://open-api.slack.com/archives/C022K8VD7AP/p1780496931264819

DmitryAnansky · 2026-06-03T13:56:12Z

+## Design principles
+
+The Arazzo specification states that when a step, success action, or failure action specifies a `workflowId`, all parameters map to the referenced workflow's inputs and the `in` field MUST NOT be specified.
+In every other case (for example, when a step specifies an `operationId`, `operationPath`, or `x-operation`, or for parameters defined at the workflow level), the `in` field MUST be specified on each parameter.


The location of the parameter. Possible values are "path", "query", "querystring", "header", or "cookie". When the step, success action, or failure action in context specifies a workflowId, then all parameters map to workflow inputs. In all other scenarios (e.g., a step specifies an operationId), the in field MUST be specified.

As in is not REQUERED, it seems to be more like => when in is not specified - then those parameters will be mapped to the workflow input when workflowId used.

DmitryAnansky · 2026-06-03T14:24:28Z

+        operationId: createTicket
+        onSuccess:
+          - name: end-with-params
+            type: end


It seems like parameters also won't make sense when action type is end.
What do you think?

DmitryAnansky · 2026-06-03T15:49:18Z

+        value: {
+          oneOf: [{ type: 'string' }, { type: 'number' }, { type: 'boolean' }],
+        },
+        'x-allowReserved': { type: 'boolean' },


Why do we need x-allowReserved here?

feat: add parameters field to Success and Failure in arrazo

5649bbd

harshit078 and others added 4 commits May 7, 2026 16:33

Merge branch 'main' into pass-workflow-input-to-actions

7646ee8

feat: added spec parameters for arrazo rules in config

c46b071

feat: added specs parameters logic and test with changeset

613e9a3

Merge branch 'main' into pass-workflow-input-to-actions

6b7e963

harshit078 marked this pull request as ready for review May 8, 2026 10:20

harshit078 requested review from a team as code owners May 8, 2026 10:20

cursor Bot reviewed May 8, 2026

View reviewed changes

Comment thread packages/core/src/rules/arazzo/spec-parameters-in-by-context.ts Outdated

AlbinaBlazhko17 reviewed May 12, 2026

View reviewed changes

Comment thread packages/core/src/rules/arazzo/spec-parameters-in-by-context.ts Outdated

harshit078 and others added 5 commits May 18, 2026 14:02

Merge branch 'main' into pass-workflow-input-to-actions

a41e2aa

fix: address comments and added docs

e057bd1

Merge branch 'main' into pass-workflow-input-to-actions

f218352

fix: failing markdownlint failing test

28c0ac1

fix: markdownlint failing test

c3223dc

harshit078 requested a review from AlbinaBlazhko17 May 18, 2026 10:04

AlbinaBlazhko17 reviewed May 20, 2026

View reviewed changes

Comment thread .changeset/swift-otters-wander.md Outdated

AlbinaBlazhko17 reviewed May 20, 2026

View reviewed changes

Comment thread packages/core/src/rules/arazzo/spec-parameters-in-by-context.ts Outdated

AlbinaBlazhko17 reviewed May 20, 2026

View reviewed changes

Comment thread docs/@v2/rules/arazzo/spec-parameters-in-by-context.md Outdated

AlbinaBlazhko17 reviewed May 20, 2026

View reviewed changes

Comment thread docs/@v2/rules/arazzo/spec-parameters-in-by-context.md Outdated

harshit078 and others added 4 commits May 20, 2026 15:15

fix: address comments and updated changset and used paramters interface

f3ffcdd

fix: added spec parameter test

db9eb6b

fix: minor lint fix

83a27cb

Merge branch 'main' into pass-workflow-input-to-actions

ffd8f5a

harshit078 requested a review from AlbinaBlazhko17 May 20, 2026 10:14

AlbinaBlazhko17 reviewed May 27, 2026

View reviewed changes

Comment thread packages/core/src/types/arazzo.ts Outdated

harshit078 and others added 3 commits May 28, 2026 15:44

fix: address comment and fix verbiage

a0470a4

Merge branch 'main' into pass-workflow-input-to-actions

ba3b600

feat: added actionParameters in replacement of parameters

667cf82

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread packages/core/src/rules/arazzo/spec-parameters-in-by-context.ts

Comment thread packages/core/src/rules/arazzo/__tests__/spec-parameters-in-by-context.test.ts Outdated

Comment thread packages/core/src/types/arazzo.ts Outdated

harshit078 added 2 commits May 28, 2026 16:00

feat: added actionParameters for workflow actions

af9e4be

fix: updated tests

8b47027

cursor Bot reviewed May 28, 2026

View reviewed changes

Comment thread packages/core/src/types/arazzo.ts

Comment thread packages/core/src/types/arazzo.ts

harshit078 added 3 commits May 28, 2026 16:28

feat: added mapParametersToWorkflowInputs function in run step for be…

d0fc683

…tter handlingg

feat: added mapParametersToWorkflowInput tests

50a990e

fix: address cursor comments

f7deff3

harshit078 requested a review from AlbinaBlazhko17 May 28, 2026 12:50

AlbinaBlazhko17 reviewed May 29, 2026

View reviewed changes

Comment thread packages/core/src/rules/arazzo/parameters-unique.ts Outdated

harshit078 and others added 4 commits May 29, 2026 20:54

fix: address comments and fix linting errors

03b6896

Merge branch 'main' into pass-workflow-input-to-actions

c095135

fix: linting errors

1ff644f

fix: failing build test

b12d4c7

harshit078 requested a review from AlbinaBlazhko17 May 29, 2026 16:06

harshit078 added 2 commits June 2, 2026 22:50

fix: failing lint test

a58b507

fix: failing lint test

41b8546

DmitryAnansky reviewed Jun 3, 2026

View reviewed changes


		## Design principles

		The Arazzo specification states that when a step, success action, or failure action specifies a `workflowId`, all parameters map to the referenced workflow's inputs and the `in` field MUST NOT be specified.

Conversation

harshit078 commented May 4, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What/Why/How?

Reference

Testing

Screenshots (optional)

Check yourself

Security

Uh oh!

changeset-bot Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

AlbinaBlazhko17 commented May 12, 2026

Uh oh!

harshit078 commented May 18, 2026

Uh oh!

AlbinaBlazhko17 May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

harshit078 commented May 28, 2026

Uh oh!

AlbinaBlazhko17 May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AlbinaBlazhko17 commented May 29, 2026

Uh oh!

harshit078 commented May 29, 2026

Uh oh!

AlbinaBlazhko17 commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harshit078 commented Jun 2, 2026

Uh oh!

DmitryAnansky Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DmitryAnansky Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

DmitryAnansky Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

DmitryAnansky Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DmitryAnansky Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

DmitryAnansky Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

DmitryAnansky Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

harshit078 commented May 4, 2026 •

edited by cursor Bot

Loading

changeset-bot Bot commented May 4, 2026 •

edited

Loading

AlbinaBlazhko17 commented Jun 2, 2026 •

edited

Loading

DmitryAnansky Jun 3, 2026 •

edited

Loading

DmitryAnansky Jun 3, 2026 •

edited

Loading