Add CHOP command to rxstrings#10
Open
neomantra wants to merge 4 commits intoRedisLabsModules:masterfrom
Open
Conversation
CHOP key count Removes characters from a value to a String key. If 'count' is positive or zero, it removes from the right of the string; if 'count' is negative, it removes from the left of the string. If |count| is greater than the string length, the value is set as an empty string. It is an error if the value is not a String. Integer Reply: the length of the string after the chop operation.
Contributor
|
@neomantra nice and useful, thanks! Looks good by a cursory glace so I plan to merge this. I'll keep this open for now until I revisit the redex modules in the near future to make them Redis v4 ready. |
Since Redis 4 was released without https://github.com/antirez/redis/pull/3718 this change was required to make CHOP work properly with Redis 4.0.0. Now all tests pass on stock Redis 4.0.0.
Contributor
Author
|
I just updated this for the released Redis 4.0.0. All tests pass. |
Open
Contributor
Author
|
Don't merge this yet? I'm exploring the generalized form discussed in #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that tests for this module will fail until this redis pull request is merged.
CHOP key count
Removes characters from a value to a String key.
If 'count' is positive or zero, it removes from the right of the string;
if 'count' is negative, it removes from the left of the string.
If |count| is greater than the string length, the value is set as an empty string.
It is an error if the value is not a String.
Integer Reply: the length of the string after the chop operation.