Open
Conversation
…l terminology** Rename `setNumThreads`/`getNumThreads` → `setParallelism`/`getParallelism` and `getThreadPoolCapacity` → `getPoolSize` across VectorSimilarity. Public info API fields (`numThreads`, `lastReservedThreads`, `NUM_THREADS`, `LAST_RESERVED_NUM_THREADS`) remain unchanged. No behavioral changes.
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
=======================================
Coverage 96.98% 96.98%
=======================================
Files 129 129
Lines 7574 7574
=======================================
Hits 7346 7346
Misses 228 228 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1: Rename SVS thread pool internal methods to match shared pool terminology
Rename
setNumThreads/getNumThreads→setParallelism/getParallelismandgetThreadPoolCapacity→getPoolSizeacross VectorSimilarity. Public info API fields (numThreads,lastReservedThreads,NUM_THREADS,LAST_RESERVED_NUM_THREADS) remain unchanged. No behavioral changes.Describe the changes in the pull request
A clear and concise description of what the PR is solving.
Which issues this PR fixes
Main objects this PR modified
Mark if applicable
Note
Low Risk
Low risk rename-only refactor that updates internal SVS/tiered SVS thread management method names and related assertions/tests, with no algorithm or data/serialization changes expected.
Overview
SVS thread-pool controls were renamed to match shared-pool terminology.
getNumThreads/setNumThreadsbecomegetParallelism/setParallelism, andgetThreadPoolCapacitybecomesgetPoolSize, including updated comments and assertions around single-vector vs bulk insert parallelism.Tiered SVS background update/GC scheduling and benchmarks/unit tests were updated to use the new method names, while debug/info fields (e.g.,
numThreads,lastReservedThreads) remain unchanged.Written by Cursor Bugbot for commit c78a851. This will update automatically on new commits. Configure here.